Issue 9429032: Fix build breakage caused by the recent toString() commit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9429032: Fix build breakage caused by the recent toString() commit. (Closed)

Created:
8 years, 10 months ago by cshapiro

Modified:
8 years, 10 months ago

Reviewers:
jjb

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix build breakage caused by the recent toString() commit. Type randomElement as returning and Object, not a void. This failed in checked mode. Rewrite another import of collections.dart to point to its new location. This broke the leg build. Committed: https://code.google.com/p/dart/source/detail?r=4422

Patch Set 1 #

Total comments: 1

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	frog/leg/lib/coreimpl.dart	View		2 chunks	+1 line, -1 line	0 comments	Download
	M	tests/corelib/src/CollectionToStringTest.dart	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jjb

8 years, 10 months ago (2012-02-22 04:55:06 UTC) #3

lgtm

Thanks for attending to this!

http://codereview.chromium.org/9429032/diff/1/tests/corelib/src/CollectionToS...
File tests/corelib/src/CollectionToStringTest.dart (right):

http://codereview.chromium.org/9429032/diff/1/tests/corelib/src/CollectionToS...
tests/corelib/src/CollectionToStringTest.dart:257: Object randomElement(int
size, bool exact, StringBuffer stringRep,
I find it astonishing that the compiler never told me about this!  I did a lot
testing, with type-checking enabled.

Expand Messages | Collapse Messages