Issue 9429028: Make dom/DocumentTest work again

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9429028: Make dom/DocumentTest work again (Closed)

Created:
8 years, 10 months ago by sra1

Modified:
8 years, 10 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make dom/DocumentTest and dom/TypingTest work again These broke in the port from WebKit to Dart test frameworks. It DocumentTest broke because it uses the document URL and the Dart framework changes the file name. Fixed by making the predicates to be less fussy. TypingTest broke because it counts style sheets and the unittest framework adds one more. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=4420

Patch Set 1 #

Patch Set 2 : x #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -6 lines)			Patch
M	client/tests/client/client.status	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	client/tests/client/dom/DocumentTest.dart	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	client/tests/client/dom/TypingTest.dart	View	3 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages