Issue 9428003: Add more file tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9428003: Add more file tests (Closed)

Created:
8 years, 10 months ago by Søren Gjesse

Modified:
8 years, 10 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add more file tests R=ager@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=4425

Patch Set 2 : Addressed review comments from ager@ #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -0 lines)			Patch
	M	tests/standalone/src/FileTest.dart	View	1	3 chunks	+58 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

lgtm https://chromiumcodereview.appspot.com/9428003/diff/1/tests/standalone/src/FileTest.dart File tests/standalone/src/FileTest.dart (right): https://chromiumcodereview.appspot.com/9428003/diff/1/tests/standalone/src/FileTest.dart#newcode440 tests/standalone/src/FileTest.dart:440: openedFile2.readListSync(data, 0, length); Maybe add an Expect.equals on ...

8 years, 10 months ago (2012-02-21 15:46:22 UTC) #2

Søren Gjesse

8 years, 10 months ago (2012-02-21 16:03:17 UTC) #3

https://chromiumcodereview.appspot.com/9428003/diff/1/tests/standalone/src/Fi...
File tests/standalone/src/FileTest.dart (right):

https://chromiumcodereview.appspot.com/9428003/diff/1/tests/standalone/src/Fi...
tests/standalone/src/FileTest.dart:440: openedFile2.readListSync(data, 0,
length);
On 2012/02/21 15:46:22, Mads Ager wrote:
> Maybe add an Expect.equals on the return value of readListSync as well?

Done.

Expand Messages | Collapse Messages

Issue 9428003: Add more file tests (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed review comments from ager@ #

Messages