Issue 9426040: Improve String and RegExp implementations.

Issue 9426040: Improve String and RegExp implementations. (Closed)

Created:
8 years, 10 months ago by ahe

Modified:
8 years, 10 months ago

Reviewers:
ngeoffray, kasperl

CC:
reviews_dartlang.org, karlklose, Lasse Reichstein Nielsen, floitsch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Improve String and RegExp implementations. Committed: https://code.google.com/p/dart/source/detail?r=4443

Patch Set 1 : changes #

Total comments: 4

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+170 lines, -77 lines)			Patch
M	dart/frog/leg/lib/js_helper.dart	View	5 chunks	+19 lines, -17 lines	0 comments	Download
M	dart/frog/leg/lib/mockimpl.dart	View	4 chunks	+14 lines, -9 lines	2 comments	Download
M	dart/frog/leg/lib/regexp_helper.dart	View	2 chunks	+9 lines, -3 lines	1 comment	Download
A	dart/frog/leg/lib/string_helper.dart	View	1 chunk	+117 lines, -0 lines	1 comment	Download
M	dart/tests/co19/co19-leg.status	View	6 chunks	+10 lines, -45 lines	0 comments	Download
M	dart/tests/corelib/corelib-leg.status	View	2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://chromiumcodereview.appspot.com/9426040/diff/1007/dart/frog/leg/lib/mockimpl.dart File dart/frog/leg/lib/mockimpl.dart (right): https://chromiumcodereview.appspot.com/9426040/diff/1007/dart/frog/leg/lib/mockimpl.dart#newcode17 dart/frog/leg/lib/mockimpl.dart:17: // TODO(ahe): Redirect to _internal when that is ...

8 years, 10 months ago (2012-02-21 12:15:53 UTC) #3

ahe

8 years, 10 months ago (2012-02-22 09:17:48 UTC) #4

Hi Kasper and Nicolas,

Thank you for going over this, I'll follow up on your excellent suggestions in
another CL.

Cheers,
Peter

Expand Messages | Collapse Messages