Issue 9425039: Implement Duration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9425039: Implement Duration. (Closed)

Created:
8 years, 10 months ago by ahe

Modified:
8 years, 10 months ago

Reviewers:
ngeoffray, kasperl

CC:
reviews_dartlang.org, karlklose, floitsch, Lasse Reichstein Nielsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add null checks in helpers so all co19 Duration tests pass. Committed: https://code.google.com/p/dart/source/detail?r=4436

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -9 lines)			Patch
M	dart/frog/leg/lib/js_helper.dart	View	17 chunks	+21 lines, -3 lines	0 comments	Download
M	dart/frog/leg/lib/mockimpl.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	dart/tests/co19/co19-leg.status	View	3 chunks	+1 line, -4 lines	0 comments	Download
M	dart/tests/language/language-leg.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

This is not really an implementation of Duration. Also, before you move forward with this ...

8 years, 10 months ago (2012-02-21 09:37:37 UTC) #3

ahe

8 years, 10 months ago (2012-02-22 09:08:29 UTC) #4

On 2012/02/21 09:37:37, ngeoffray wrote:
> This is not really an implementation of Duration. Also, before you move
forward
> with this CL and the others, I would like to talk to you about all these
> checkNull.

I plan to move forward with this CL and the others. If checkNull is a problem, I
will clean it up in a follow-up CL.

I'll change the name of the CL.

Expand Messages | Collapse Messages