Issue 9424027: Implement Date.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9424027: Implement Date. (Closed)

Created:
8 years, 10 months ago by ahe

Modified:
8 years, 10 months ago

Reviewers:
ngeoffray, kasperl

CC:
reviews_dartlang.org, karlklose, floitsch, Lasse Reichstein Nielsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Implement Date. Committed: https://code.google.com/p/dart/source/detail?r=4435

Patch Set 1 #

Total comments: 2

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+241 lines, -373 lines)			Patch
M	dart/frog/leg/frog_leg.dart	View	1 chunk	+7 lines, -2 lines	1 comment	Download
M	dart/frog/leg/lib/coreimpl.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
A	dart/frog/leg/lib/date_helper.dart	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	dart/frog/leg/lib/js_helper.dart	View	4 chunks	+115 lines, -23 lines	0 comments	Download
M	dart/frog/leg/lib/mockimpl.dart	View	4 chunks	+94 lines, -276 lines	1 comment	Download
M	dart/tests/co19/co19-leg.status	View	6 chunks	+9 lines, -70 lines	0 comments	Download
M	dart/tests/language/language-leg.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://chromiumcodereview.appspot.com/9424027/diff/1/dart/frog/leg/frog_leg.dart File dart/frog/leg/frog_leg.dart (right): https://chromiumcodereview.appspot.com/9424027/diff/1/dart/frog/leg/frog_leg.dart#newcode126 dart/frog/leg/frog_leg.dart:126: return; We usually do not return after a ...

8 years, 10 months ago (2012-02-21 07:23:29 UTC) #2

ngeoffray

LGTM https://chromiumcodereview.appspot.com/9424027/diff/1/dart/frog/leg/lib/mockimpl.dart File dart/frog/leg/lib/mockimpl.dart (right): https://chromiumcodereview.appspot.com/9424027/diff/1/dart/frog/leg/lib/mockimpl.dart#newcode162 dart/frog/leg/lib/mockimpl.dart:162: // Adjust by one because JS weeks start ...

8 years, 10 months ago (2012-02-21 12:08:07 UTC) #3

ahe

8 years, 10 months ago (2012-02-22 09:05:00 UTC) #4

Hi Kasper and Nicolas,

Thank you.

I'll follow up on your comments in a new CL.

Cheers,
Peter

Expand Messages | Collapse Messages