Issue 9422011: Third time's the charm...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9422011: Third time's the charm... (Closed)

Created:
8 years, 10 months ago by Emily Fortuna

Modified:
8 years, 10 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Third time's the charm... TBR=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=4372

Patch Set 1 : #

Total comments: 1

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	tools/testing/dart/test_runner.dart	View		1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

8 years, 10 months ago (2012-02-17 22:04:13 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/9422011/diff/3/tools/testing/dart/test...
File tools/testing/dart/test_runner.dart (right):

https://chromiumcodereview.appspot.com/9422011/diff/3/tools/testing/dart/test...
tools/testing/dart/test_runner.dart:255: RunningProcess(TestCase this.testCase,
[this.allowRetries]);
The alternative is to do it here:
 RunningProcess(TestCase this.testCase, [allowRetries=false]) : _allowRetries =
allowRetries;
(assuming we rename the field to _allowRetries)

Expand Messages | Collapse Messages