Improve double implementation.

Improve double implementation.

Committed: https://code.google.com/p/dart/source/detail?r=4430

[kasperl, 2012-02-21 07:29:02]

LGTM.

https://chromiumcodereview.appspot.com/9421025/diff/1/dart/frog/leg/lib/js_he...
File dart/frog/leg/lib/js_helper.dart (right):

https://chromiumcodereview.appspot.com/9421025/diff/1/dart/frog/leg/lib/js_he...
dart/frog/leg/lib/js_helper.dart:746: return JS("double", @"$0 + 0", receiver);
If you're going for a ToNumber conversion here, maybe simply emit +$0?

[ngeoffray, 2012-02-21 12:10:31]

LGTM

[floitsch, 2012-02-21 13:34:02]

DBC

https://chromiumcodereview.appspot.com/9421025/diff/1/dart/frog/leg/lib/js_he...
File dart/frog/leg/lib/js_helper.dart (right):

https://chromiumcodereview.appspot.com/9421025/diff/1/dart/frog/leg/lib/js_he...
dart/frog/leg/lib/js_helper.dart:746: return JS("double", @"$0 + 0", receiver);
On 2012/02/21 07:29:02, kasperl wrote:
> If you're going for a ToNumber conversion here, maybe simply emit +$0?

There is an is !num check just above. No need to do anything else. Just return
the receiver.
'+$0' is not free and we shouldn't need it here.

[ahe, 2012-02-22 07:55:27]

Hi Kasper, Nicolas, and Florian,

Thank you for your suggestions.

I'll address the issue with + 0 in a follow-up CL.

Cheers,
Peter

[ahe, 2012-04-20 10:51:03]

https://chromiumcodereview.appspot.com/9421025/diff/1/dart/frog/leg/lib/js_he...
File dart/frog/leg/lib/js_helper.dart (right):

https://chromiumcodereview.appspot.com/9421025/diff/1/dart/frog/leg/lib/js_he...
dart/frog/leg/lib/js_helper.dart:746: return JS("double", @"$0 + 0", receiver);
On 2012/02/21 13:34:02, floitsch wrote:
> On 2012/02/21 07:29:02, kasperl wrote:
> > If you're going for a ToNumber conversion here, maybe simply emit +$0?
> 
> There is an is !num check just above. No need to do anything else. Just return
> the receiver.
> '+$0' is not free and we shouldn't need it here.

Follow-up in https://chromiumcodereview.appspot.com/10134004