Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 9421002: Issue 1714. Report warning if assert argument is not 'bool' or '() -> bool'. (Closed)

Created:
8 years, 10 months ago by scheglov
Modified:
8 years, 10 months ago
Reviewers:
codefu, zundel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Issue 1714. Report warning if assert argument is not 'bool' or '() -> bool'. http://code.google.com/p/dart/issues/detail?id=1714 R=codefu@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=4404

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java View 1 chunk +5 lines, -4 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java View 2 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
8 years, 10 months ago (2012-02-17 17:00:35 UTC) #1
codefu
8 years, 10 months ago (2012-02-21 18:09:36 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698