Use shared implementation of Stopwatch.

Use shared implementation of Stopwatch.

Alos, mock up an implementation of interface constructors.

Committed: https://code.google.com/p/dart/source/detail?r=4357

[ngeoffray, 2012-02-17 09:45:21]

Initial comments, this is doing much more than what the subject pretends it's
doing :)

https://chromiumcodereview.appspot.com/9419009/diff/1/dart/frog/leg/elements/...
File dart/frog/leg/elements/elements.dart (right):

https://chromiumcodereview.appspot.com/9419009/diff/1/dart/frog/leg/elements/...
dart/frog/leg/elements/elements.dart:392:
FunctionElement.tooMuchOverloading(SourceString name,
Unsurprisingly, this is too much. Why didn't you keep the previous way of doing
it? There was basically three cases:
- element created by the diet-parser (FunctionElement)
- element created for nested functions (FunctionElement.node)
- element created by the backend (FunctionElement.from).

I don't think you need to change that. Maybe the name FunctionElement.node
should be changed to FunctionElement.nested, to make it clearer?

Also this 'implementation' element, is that just for constructors in interfaces?
I'd prefer another name, like defaultImplementation.

https://chromiumcodereview.appspot.com/9419009/diff/1/dart/frog/leg/lib/clock...
File dart/frog/leg/lib/clock.dart (right):

https://chromiumcodereview.appspot.com/9419009/diff/1/dart/frog/leg/lib/clock...
dart/frog/leg/lib/clock.dart:20: 
extra line

https://chromiumcodereview.appspot.com/9419009/diff/1/dart/frog/leg/resolver....
File dart/frog/leg/resolver.dart (right):

https://chromiumcodereview.appspot.com/9419009/diff/1/dart/frog/leg/resolver....
dart/frog/leg/resolver.dart:114: if (constructor.implementation === null) {
Maybe add a comment here that you're looking for the constructor with the name
of the default class, instead of the interface.

https://chromiumcodereview.appspot.com/9419009/diff/1/dart/frog/leg/resolver....
dart/frog/leg/resolver.dart:122: && new SourceString(name) == defaultClass.name
You could share new SourceString(name) with line 119

https://chromiumcodereview.appspot.com/9419009/diff/1/dart/frog/leg/resolver....
dart/frog/leg/resolver.dart:123: &&
constructor.functionParameters.parameterCount === 0) {
constructor.computeParameters(compiler).parameterCount

https://chromiumcodereview.appspot.com/9419009/diff/1/dart/frog/leg/resolver....
dart/frog/leg/resolver.dart:127: if (constructor === null) {
This case cannot happen.

https://chromiumcodereview.appspot.com/9419009/diff/1/dart/frog/leg/resolver....
dart/frog/leg/resolver.dart:866: handleArguments(node.send);
This should still be done at the end, otherwise you'll get errors on the
arguments before errors on the type/

[ngeoffray, 2012-02-17 14:42:45]

And LGTM

[ahe, 2012-02-17 15:43:10]

Hi Nicolas,

Thank you for you suggestions and comments.

Cheers,
Peter

https://chromiumcodereview.appspot.com/9419009/diff/1/dart/frog/leg/elements/...
File dart/frog/leg/elements/elements.dart (right):

https://chromiumcodereview.appspot.com/9419009/diff/1/dart/frog/leg/elements/...
dart/frog/leg/elements/elements.dart:392:
FunctionElement.tooMuchOverloading(SourceString name,
On 2012/02/17 09:45:21, ngeoffray wrote:
> Unsurprisingly, this is too much. Why didn't you keep the previous way of
doing
> it? There was basically three cases:
> - element created by the diet-parser (FunctionElement)
> - element created for nested functions (FunctionElement.node)
> - element created by the backend (FunctionElement.from).
> 
> I don't think you need to change that. Maybe the name FunctionElement.node
> should be changed to FunctionElement.nested, to make it clearer?

As we discussed, I'd like to raise the abstraction level for building elements
and plan to return to this.

> Also this 'implementation' element, is that just for constructors in
interfaces?
> I'd prefer another name, like defaultImplementation.

Great idea. I have changed the name.

https://chromiumcodereview.appspot.com/9419009/diff/1/dart/frog/leg/lib/clock...
File dart/frog/leg/lib/clock.dart (right):

https://chromiumcodereview.appspot.com/9419009/diff/1/dart/frog/leg/lib/clock...
dart/frog/leg/lib/clock.dart:20: 
On 2012/02/17 09:45:21, ngeoffray wrote:
> extra line

Done.

https://chromiumcodereview.appspot.com/9419009/diff/1/dart/frog/leg/resolver....
File dart/frog/leg/resolver.dart (right):

https://chromiumcodereview.appspot.com/9419009/diff/1/dart/frog/leg/resolver....
dart/frog/leg/resolver.dart:114: if (constructor.implementation === null) {
On 2012/02/17 09:45:21, ngeoffray wrote:
> Maybe add a comment here that you're looking for the constructor with the name
> of the default class, instead of the interface.

Done.

https://chromiumcodereview.appspot.com/9419009/diff/1/dart/frog/leg/resolver....
dart/frog/leg/resolver.dart:122: && new SourceString(name) == defaultClass.name
On 2012/02/17 09:45:21, ngeoffray wrote:
> You could share new SourceString(name) with line 119

Done.

https://chromiumcodereview.appspot.com/9419009/diff/1/dart/frog/leg/resolver....
dart/frog/leg/resolver.dart:123: &&
constructor.functionParameters.parameterCount === 0) {
On 2012/02/17 09:45:21, ngeoffray wrote:
> constructor.computeParameters(compiler).parameterCount

Done.

https://chromiumcodereview.appspot.com/9419009/diff/1/dart/frog/leg/resolver....
dart/frog/leg/resolver.dart:127: if (constructor === null) {
On 2012/02/17 09:45:21, ngeoffray wrote:
> This case cannot happen.

Done.

https://chromiumcodereview.appspot.com/9419009/diff/1/dart/frog/leg/resolver....
dart/frog/leg/resolver.dart:866: handleArguments(node.send);
On 2012/02/17 09:45:21, ngeoffray wrote:
> This should still be done at the end, otherwise you'll get errors on the
> arguments before errors on the type/

Done.