Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 9416110: remove end script tag from comment (Closed)

Created:
8 years, 10 months ago by mattsh
Modified:
8 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

remove end script tag from comment BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=4492

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/testing/frogpad/frogpad.dart View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 4 (0 generated)
mattsh
The </script> tag that i had in one of my comments was messing up self ...
8 years, 10 months ago (2012-02-22 21:19:17 UTC) #1
Jennifer Messerly
lgtm
8 years, 10 months ago (2012-02-22 21:23:13 UTC) #2
Siggi Cherem (dart-lang)
https://chromiumcodereview.appspot.com/9416110/diff/1/tools/testing/frogpad/frogpad.dart File tools/testing/frogpad/frogpad.dart (left): https://chromiumcodereview.appspot.com/9416110/diff/1/tools/testing/frogpad/frogpad.dart#oldcode107 tools/testing/frogpad/frogpad.dart:107: * </script> Please add a TODO somewhere about handling ...
8 years, 10 months ago (2012-02-22 21:54:10 UTC) #3
mattsh
8 years, 10 months ago (2012-02-22 21:57:29 UTC) #4
https://chromiumcodereview.appspot.com/9416110/diff/1/tools/testing/frogpad/f...
File tools/testing/frogpad/frogpad.dart (left):

https://chromiumcodereview.appspot.com/9416110/diff/1/tools/testing/frogpad/f...
tools/testing/frogpad/frogpad.dart:107: *   </script>
On 2012/02/22 21:54:10, sigmund wrote:
> Please add a TODO somewhere about handling this more gracefully. Probably the
> solution should be to either convert the code or escape the string "</script>"
> somehow.
> 
> I should be able to write a program with this:
> 
>   return "</script>"
> 
> and not break frogpad.

Yes, good point.

Powered by Google App Engine
This is Rietveld 408576698