Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 9416102: Reduce run-time of two longest running tests (checked mode). (Closed)

Created:
8 years, 10 months ago by srdjan
Modified:
8 years, 10 months ago
Reviewers:
jjb, regis
CC:
reviews_dartlang.org, jjb
Visibility:
Public.

Description

Reduce run-time of two longest running tests (checked mode). Committed: https://code.google.com/p/dart/source/detail?r=4474

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M tests/corelib/src/CollectionToStringTest.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/language/src/MathVMTest.dart View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
8 years, 10 months ago (2012-02-22 17:25:21 UTC) #1
regis
LGTM
8 years, 10 months ago (2012-02-22 17:40:10 UTC) #2
jjb
8 years, 10 months ago (2012-02-22 21:54:57 UTC) #3
For the record, it scares me that we have to reduce the number of tests this
far.  The code being tested is simple enough that I'm confident that it works,
but we should be able to do more testing than this without using excessive clock
time.  I  was originally running *thousands* of tests on a machine that runs
*billions* of instructions per second; now we're running hudreds. Hopefully
things will get faster, enabling us to run more thorough tests.

Powered by Google App Engine
This is Rietveld 408576698