Issue 9416096: Implement File.directory() and File.directorySync() to get

Issue 9416096: Implement File.directory() and File.directorySync() to get (Closed)

Created:
8 years, 10 months ago by Mads Ager (google)

Modified:
8 years, 10 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Implement File.directory() and File.directorySync() to get containing directory for a file. BUG=dart:1618 TEST=standalone/FileTest Committed: https://code.google.com/p/dart/source/detail?r=4464

Patch Set 3 : Windows implementation. #

Patch Set 4 : Implement async version using isolate #

Total comments: 2

Patch Set 5 : Fix type typos #

Patch Set 6 : Remove bogus assert #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+201 lines, -16 lines)			Patch
M	runtime/bin/builtin_natives.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/file.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/file.cc	View		1 chunk	+15 lines, -0 lines	0 comments	Download
M	runtime/bin/file.dart	View	1	2 chunks	+20 lines, -0 lines	0 comments	Download
M	runtime/bin/file_impl.dart	View	1 2 3 4	5 chunks	+50 lines, -0 lines	0 comments	Download
M	runtime/bin/file_linux.cc	View	1 2 3 4 5	1 chunk	+9 lines, -0 lines	0 comments	Download
M	runtime/bin/file_macos.cc	View	1 2 3 4 5	1 chunk	+9 lines, -0 lines	0 comments	Download
M	runtime/bin/file_win.cc	View	1 2 3 4 5	1 chunk	+14 lines, -0 lines	0 comments	Download
M	tests/standalone/src/FileTest.dart	View	1 2 3	3 chunks	+82 lines, -16 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

I will be happy to wait with committing this until the native ports version of ...

8 years, 10 months ago (2012-02-22 16:04:51 UTC) #1

Søren Gjesse

lgtm https://chromiumcodereview.appspot.com/9416096/diff/6001/runtime/bin/file_linux.cc File runtime/bin/file_linux.cc (right): https://chromiumcodereview.appspot.com/9416096/diff/6001/runtime/bin/file_linux.cc#newcode181 runtime/bin/file_linux.cc:181: ASSERT(Exists(pathname)); Isn't this ASSERT dangerous? Any file can ...

8 years, 10 months ago (2012-02-22 16:13:07 UTC) #2

Mads Ager (google)

8 years, 10 months ago (2012-02-22 16:17:27 UTC) #3

https://chromiumcodereview.appspot.com/9416096/diff/6001/runtime/bin/file_lin...
File runtime/bin/file_linux.cc (right):

https://chromiumcodereview.appspot.com/9416096/diff/6001/runtime/bin/file_lin...
runtime/bin/file_linux.cc:181: ASSERT(Exists(pathname));
On 2012/02/22 16:13:08, Søren Gjesse wrote:
> Isn't this ASSERT dangerous? Any file can disappear at any time.

Good point. Removed on all platforms.

Expand Messages | Collapse Messages