Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 9416084: Implement more missing pieces in VM's core library. Although it does not seem to make sense to have… (Closed)

Created:
8 years, 10 months ago by srdjan
Modified:
8 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Implement more missing pieces in VM's core library. Although it does not seem to make sense to have toStringAsFixed, toStringAsExponential and toStringAsPrecision in integers, the interface 'num' specifies them, most likely because of troubles in Javascript versions. Note that Double_toStringAsExponential and Double_toStringAsPrecision are still unimplemented in C++. Instead of crashing, throw an exception. Also fix argument passing. Committed: https://code.google.com/p/dart/source/detail?r=4463

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M runtime/lib/integers.dart View 1 2 1 chunk +3 lines, -6 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
8 years, 10 months ago (2012-02-22 01:34:43 UTC) #1
floitsch
FYI: https://chromiumcodereview.appspot.com/9113043/ http://code.google.com/p/dart/issues/detail?id=1327 Integer change LGTM (assuming that toDouble is accepted behavior).
8 years, 10 months ago (2012-02-22 09:40:33 UTC) #2
srdjan
8 years, 10 months ago (2012-02-22 15:19:50 UTC) #3
On 2012/02/22 09:40:33, floitsch wrote:
> FYI:
> https://chromiumcodereview.appspot.com/9113043/
> http://code.google.com/p/dart/issues/detail?id=1327
> 
> Integer change LGTM (assuming that toDouble is accepted behavior).

Reverted changes conflicting with Issue 9113043, leaving integer changes only.

Powered by Google App Engine
This is Rietveld 408576698