Issue 9416067: Fix cacthing exception object: a null exception is always caught.

Issue 9416067: Fix cacthing exception object: a null exception is always caught. (Closed)

Created:
8 years, 10 months ago by srdjan

Modified:
8 years, 10 months ago

Reviewers:
mattsh, hausner

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix cacthing exception object: a null exception is always caught. Committed: https://code.google.com/p/dart/source/detail?r=4411

Patch Set 3 : #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -3 lines)			Patch
M	runtime/vm/parser.cc	View	1 2	2 chunks	+17 lines, -3 lines	0 comments	Download
M	tests/language/language.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/language/language-leg.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/language/src/ExceptionTest.dart	View	1 2	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

hausner

LGTM w/comment. https://chromiumcodereview.appspot.com/9416067/diff/2001/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://chromiumcodereview.appspot.com/9416067/diff/2001/runtime/vm/parser.cc#newcode4931 runtime/vm/parser.cc:4931: catch_pos, Token::kOR, null_cond_expr, type_cond_expr); As discussed offline, ...

8 years, 10 months ago (2012-02-21 21:46:41 UTC) #2

hausner

One more thing... https://chromiumcodereview.appspot.com/9416067/diff/2001/tests/language/src/ExceptionTest.dart File tests/language/src/ExceptionTest.dart (right): https://chromiumcodereview.appspot.com/9416067/diff/2001/tests/language/src/ExceptionTest.dart#newcode25 tests/language/src/ExceptionTest.dart:25: // null exception object is caught ...

8 years, 10 months ago (2012-02-21 21:47:48 UTC) #3

srdjan

https://chromiumcodereview.appspot.com/9416067/diff/2001/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://chromiumcodereview.appspot.com/9416067/diff/2001/runtime/vm/parser.cc#newcode4931 runtime/vm/parser.cc:4931: catch_pos, Token::kOR, null_cond_expr, type_cond_expr); On 2012/02/21 21:46:41, hausner wrote: ...

8 years, 10 months ago (2012-02-21 21:53:52 UTC) #4

mattsh

https://chromiumcodereview.appspot.com/9416067/diff/2001/tests/language/language.status File tests/language/language.status (right): https://chromiumcodereview.appspot.com/9416067/diff/2001/tests/language/language.status#newcode230 tests/language/language.status:230: ExceptionTest: Fail # Issue 1758 I think the bug ...

8 years, 10 months ago (2012-02-21 21:59:04 UTC) #5

srdjan

8 years, 10 months ago (2012-02-21 22:15:11 UTC) #6

https://chromiumcodereview.appspot.com/9416067/diff/2001/tests/language/langu...
File tests/language/language.status (right):

https://chromiumcodereview.appspot.com/9416067/diff/2001/tests/language/langu...
tests/language/language.status:230: ExceptionTest: Fail # Issue 1758
On 2012/02/21 21:59:04, mattsh wrote:
> I think the bug number here is incorrect (should be 1785, not 1758, no?)

Thanks for catching it!

Expand Messages | Collapse Messages