Support generation of constructors in the most common case.

Support generation of constructors in the most common case.

Committed: https://code.google.com/p/dart/source/detail?r=4380

[antonm, 2012-02-17 15:32:17]

See also https://chromiumcodereview.appspot.com/9420050/

[podivilov, 2012-02-17 17:47:20]

http://codereview.chromium.org/9416062/diff/1/client/dom/scripts/dartgenerato...
File client/dom/scripts/dartgenerator.py (right):

http://codereview.chromium.org/9416062/diff/1/client/dom/scripts/dartgenerato...
client/dom/scripts/dartgenerator.py:2720: if self._IsConstructable() and
self._interface.id not in UNSUPPORTED_CONSTRUCTORS_WITH_ARGS:
Please use early return.

http://codereview.chromium.org/9416062/diff/1/client/dom/scripts/dartgenerato...
client/dom/scripts/dartgenerator.py:2726: if self._interface.id not in
SUPPORTED_CONSTRUCTORS_WITH_ARGS and 'Constructor' in self._interface.ext_attrs:
Early return as well: if custom, just emit declaration and return.

http://codereview.chromium.org/9416062/diff/1/client/dom/scripts/dartgenerato...
client/dom/scripts/dartgenerator.py:3084: self._GenerateNativeCallbackBase(
I think such trampolines make the code messy. Could you please avoid them?

http://codereview.chromium.org/9416062/diff/1/client/dom/scripts/dartgenerato...
client/dom/scripts/dartgenerator.py:3100: callback = '%s(%s)' % (function_name,
', '.join(arguments))
Could you please replace "function_name, arguments" with "invocation", and
include receiver declaration in parameter_definitions? It would require some
duplication, but will result in a clean and straightforward code.

[antonm, 2012-02-20 14:28:16]

PTAL.

After our discussions, I think it might be the best way out.

WDYT?

[podivilov, 2012-02-20 15:00:50]

lgtm