Issue 9416033: don't retry if the browser is dumprendertree?

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9416033: don't retry if the browser is dumprendertree? (Closed)

Created:
8 years, 10 months ago by Jennifer Messerly

Modified:
8 years, 10 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

don't retry if the browser is dumprendertree Committed: https://code.google.com/p/dart/source/detail?r=4340

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
	M	tools/testing/dart/test_runner.dart	View		4 chunks	+9 lines, -9 lines	0 comments	Download

Total messages: 2 (0 generated)

Jennifer Messerly

Hey Emily, Does this change seem okay? Siggi was asking me if we could avoid ...

8 years, 10 months ago (2012-02-16 21:01:06 UTC) #1

Emily Fortuna

8 years, 10 months ago (2012-02-16 21:10:26 UTC) #2

lgtm. We only want to retry DRT in the very specific case (which we're already
doing), so this just makes our set of retry test cases more specific.