Issue 9415005: Support implicitly bound closures (aka. tear-off closures).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9415005: Support implicitly bound closures (aka. tear-off closures). (Closed)

Created:
8 years, 10 months ago by floitsch

Modified:
8 years, 10 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support implicitly bound closures (aka. tear-off closures). Committed: https://code.google.com/p/dart/source/detail?r=4312

Patch Set 2 : Address comments. #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+107 lines, -21 lines)			Patch
M	frog/leg/compiler.dart	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	frog/leg/emitter.dart	View	1	2 chunks	+81 lines, -0 lines	0 comments	Download
M	frog/leg/namer.dart	View	1	3 chunks	+21 lines, -20 lines	0 comments	Download
M	tests/language/language-leg.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM! https://chromiumcodereview.appspot.com/9415005/diff/1/frog/leg/emitter.dart File frog/leg/emitter.dart (right): https://chromiumcodereview.appspot.com/9415005/diff/1/frog/leg/emitter.dart#newcode303 frog/leg/emitter.dart:303: // foo$get() { return new BoundClosure499(this); } foo$get ...

8 years, 10 months ago (2012-02-16 12:38:46 UTC) #2

floitsch

8 years, 10 months ago (2012-02-16 13:43:07 UTC) #3

https://chromiumcodereview.appspot.com/9415005/diff/1/frog/leg/emitter.dart
File frog/leg/emitter.dart (right):

https://chromiumcodereview.appspot.com/9415005/diff/1/frog/leg/emitter.dart#n...
frog/leg/emitter.dart:303: //    foo$get() { return new BoundClosure499(this); }
On 2012/02/16 12:38:46, ngeoffray wrote:
> foo$get -> get foo ?

Done.

https://chromiumcodereview.appspot.com/9415005/diff/1/frog/leg/namer.dart
File frog/leg/namer.dart (right):

https://chromiumcodereview.appspot.com/9415005/diff/1/frog/leg/namer.dart#new...
frog/leg/namer.dart:117: String _computeFreshGlobalName(Element element) {
On 2012/02/16 12:38:46, ngeoffray wrote:
> I would remove this method, it's only called once, and we always want to have
a
> 'guess' for an element, so line 134 (old revision) should be kept.

Done.

Expand Messages | Collapse Messages

Issue 9415005: Support implicitly bound closures (aka. tear-off closures). (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comments. #

Messages