Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 9414032: Add the vm internal dart tests into the test suite. (Closed)

Created:
8 years, 10 months ago by turnidge
Modified:
8 years, 10 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org, siva
Visibility:
Public.

Description

Add the vm internal dart tests into the test suite. Committed: https://code.google.com/p/dart/source/detail?r=5113

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -21 lines) Patch
A + runtime/tests/vm/src/ImportMapTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D runtime/tests/vm/src/test1.dart View 1 2 1 chunk +0 lines, -22 lines 0 comments Download
M runtime/tests/vm/test_config.dart View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
A runtime/tests/vm/vm_dart.status View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M tools/test.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tools/test-runtime.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
turnidge
8 years, 10 months ago (2012-02-17 01:32:54 UTC) #1
Bill Hesse
The change looks fine, but what is the motivation for creating tests here rather than ...
8 years, 10 months ago (2012-02-17 09:08:26 UTC) #2
turnidge
The difference is slight. My conceptual distinction is that standalone tests are primarily aimed at ...
8 years, 10 months ago (2012-02-17 17:54:14 UTC) #3
Bill Hesse
8 years, 10 months ago (2012-02-23 15:04:58 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld 408576698