Issue 9414015: Issue 1551. Report error for new-line in single-line raw string.

Issue 9414015: Issue 1551. Report error for new-line in single-line raw string. (Closed)

Created:
8 years, 10 months ago by scheglov

Modified:
8 years, 10 months ago

Reviewers:
codefu, zundel

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 1551. Report error for new-line in single-line raw string. http://code.google.com/p/dart/issues/detail?id=1551 R=codefu@google.com,zundel@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=4332

Patch Set 1 #

Total comments: 2

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -5 lines)			Patch
M	compiler/java/com/google/dart/compiler/parser/DartScanner.java	View	2 chunks	+6 lines, -1 line	2 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/ParserEventsTest.java	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/StringsErrorsNegativeTest.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/ValidatingSyntaxTest.java	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

codefu

https://chromiumcodereview.appspot.com/9414015/diff/1/compiler/java/com/google/dart/compiler/parser/DartScanner.java File compiler/java/com/google/dart/compiler/parser/DartScanner.java (right): https://chromiumcodereview.appspot.com/9414015/diff/1/compiler/java/com/google/dart/compiler/parser/DartScanner.java#newcode883 compiler/java/com/google/dart/compiler/parser/DartScanner.java:883: } else if (c == '\n' && !multiLine) { ...

8 years, 10 months ago (2012-02-16 18:59:38 UTC) #2

scheglov

8 years, 10 months ago (2012-02-16 19:13:26 UTC) #3

codefu

8 years, 10 months ago (2012-02-16 19:16:35 UTC) #4

On 2012/02/16 19:13:26, scheglov wrote:
>
https://chromiumcodereview.appspot.com/9414015/diff/1/compiler/java/com/googl...
> File compiler/java/com/google/dart/compiler/parser/DartScanner.java (right):
> 
>
https://chromiumcodereview.appspot.com/9414015/diff/1/compiler/java/com/googl...
> compiler/java/com/google/dart/compiler/parser/DartScanner.java:883: } else if
(c
> == '\n' && !multiLine) {
> On 2012/02/16 18:59:38, codefu wrote:
> > Will this catch the case on windows as well?
> 
> Yes, on Windows \r\n is used.

LGTM...  my only concern was the token offsets being off.  It would take a
"unix2dos" of the file to change a n to a rn and the tests would fail; fragile
to external forces.

Expand Messages | Collapse Messages