Fix issue 979: operator arity must be verified.

Fix issue 979: operator arity must be verified.
Committed: https://code.google.com/p/dart/source/detail?r=4401

[hausner, 2012-02-16 17:39:36]

Technically LGTM but I have a suggestion how to do this less heavy-handedly. See
below.

https://chromiumcodereview.appspot.com/9414005/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://chromiumcodereview.appspot.com/9414005/diff/1/runtime/vm/parser.cc#ne...
runtime/vm/parser.cc:2478: CheckOperatorArity(member);
Suggestion. I think this is unnecessarily complicated. In CheckOperatorArity you
have to create several handles and do string compares to figure out which
operator we're dealing with and what the expected arity is.

Instead, you could remember the operator token a few lines above and pass it to
CheckOperatorArity(). You also don't need the is_operator field in MemberDesc. A
local boolean variable here would be enough to remember that you need to call
CheckOperatorArity.

[srdjan, 2012-02-21 17:20:08]

On 2012/02/16 17:39:36, hausner wrote:
> Technically LGTM but I have a suggestion how to do this less heavy-handedly.
See
> below.
> 
> https://chromiumcodereview.appspot.com/9414005/diff/1/runtime/vm/parser.cc
> File runtime/vm/parser.cc (right):
> 
>
https://chromiumcodereview.appspot.com/9414005/diff/1/runtime/vm/parser.cc#ne...
> runtime/vm/parser.cc:2478: CheckOperatorArity(member);
> Suggestion. I think this is unnecessarily complicated. In CheckOperatorArity
you
> have to create several handles and do string compares to figure out which
> operator we're dealing with and what the expected arity is.
> 
> Instead, you could remember the operator token a few lines above and pass it
to
> CheckOperatorArity(). You also don't need the is_operator field in MemberDesc.
A
> local boolean variable here would be enough to remember that you need to call
> CheckOperatorArity.

Changed as suggested.