Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 9413003: Thread the weak persistent handle free-list through the raw_ field. (Closed)

Created:
8 years, 10 months ago by cshapiro
Modified:
8 years, 10 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Thread the weak persistent handle free-list through the raw_ field. As free-list pointers are either the address of the next free handle or NULL, raw_ fields should conveniently appear as a smi and be ignored during weak reference processing. Ordinary persistent handles already reuse the raw_ field for this purpose and rely on confusing free-list links with tagged smi values. Of course, nothing strictly requires that the addresses of handles be aligned in just the right way. So, just in case, new asserts check that raw_ field values are not confusable with tagged heap addresses. Committed: https://code.google.com/p/dart/source/detail?r=4423

Patch Set 1 #

Patch Set 2 : no change #

Patch Set 3 : no change #

Patch Set 4 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M runtime/vm/dart_api_state.h View 1 2 3 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
cshapiro
8 years, 10 months ago (2012-02-16 06:19:19 UTC) #1
siva
8 years, 10 months ago (2012-02-17 23:02:12 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698