Throw NoSuchMethod or IllegalArgument on bad operators or bad arguments to

Throw NoSuchMethod or IllegalArgument on bad operators or bad arguments to
binary expressions.

Fixes Issue 1588

Committed: https://code.google.com/p/dart/source/detail?r=4260

[kasperl, 2012-02-15 11:54:48]

LGTM.

https://chromiumcodereview.appspot.com/9408001/diff/1/frog/corejs.dart
File frog/corejs.dart (right):

https://chromiumcodereview.appspot.com/9408001/diff/1/frog/corejs.dart#newcode49
frog/corejs.dart:49:
world.gen.markTypeUsed(world.corelib.types['NoSuchMethodException']);
How about adding a helper for this statement?

https://chromiumcodereview.appspot.com/9408001/diff/1/frog/corejs.dart#newcod...
frog/corejs.dart:209: return (typeof(x) != 'object') ? x !== y : !x.$eq(y);
This changes things for functions, right? I guess that's intentional?

https://chromiumcodereview.appspot.com/9408001/diff/1/frog/corejs.dart#newcod...
frog/corejs.dart:242: if (typeof(x) == 'number') {
It's hard to understand what this does for performance. Would it be possible to
only cover the number case in this method and call some other method
$add$complex for the other cases so the simple case can be inlined without
dragging everything in? This might make sense for the generic _otherOperator
too.

https://chromiumcodereview.appspot.com/9408001/diff/1/frog/corejs.dart#newcod...
frog/corejs.dart:263: if  (typeof(y) == 'number') {
if  ( -> if (

https://chromiumcodereview.appspot.com/9408001/diff/1/tests/language/src/Stri...
File tests/language/src/StringConcatTest.dart (right):

https://chromiumcodereview.appspot.com/9408001/diff/1/tests/language/src/Stri...
tests/language/src/StringConcatTest.dart:49: // TODO(floitsch):
IllegalArgumentException might not be correct.
Maybe explain this one a bit better? Is the string concatenation operator
throwing the wrong argument? I guess so.

[floitsch, 2012-02-15 13:11:42]

https://chromiumcodereview.appspot.com/9408001/diff/1/frog/corejs.dart
File frog/corejs.dart (right):

https://chromiumcodereview.appspot.com/9408001/diff/1/frog/corejs.dart#newcode49
frog/corejs.dart:49:
world.gen.markTypeUsed(world.corelib.types['NoSuchMethodException']);
On 2012/02/15 11:54:49, kasperl wrote:
> How about adding a helper for this statement?

Done.

https://chromiumcodereview.appspot.com/9408001/diff/1/frog/corejs.dart#newcod...
frog/corejs.dart:209: return (typeof(x) != 'object') ? x !== y : !x.$eq(y);
On 2012/02/15 11:54:49, kasperl wrote:
> This changes things for functions, right? I guess that's intentional?

AFAICS functions don't override the $eq method and would use the one on
Object.prototype which does ===. So everything stays the same.

https://chromiumcodereview.appspot.com/9408001/diff/1/frog/corejs.dart#newcod...
frog/corejs.dart:242: if (typeof(x) == 'number') {
On 2012/02/15 11:54:49, kasperl wrote:
> It's hard to understand what this does for performance. Would it be possible
to
> only cover the number case in this method and call some other method
> $add$complex for the other cases so the simple case can be inlined without
> dragging everything in? This might make sense for the generic _otherOperator
> too.

Done.

https://chromiumcodereview.appspot.com/9408001/diff/1/frog/corejs.dart#newcod...
frog/corejs.dart:263: if  (typeof(y) == 'number') {
On 2012/02/15 11:54:49, kasperl wrote:
> if  ( -> if (

Done.

https://chromiumcodereview.appspot.com/9408001/diff/1/tests/language/src/Stri...
File tests/language/src/StringConcatTest.dart (right):

https://chromiumcodereview.appspot.com/9408001/diff/1/tests/language/src/Stri...
tests/language/src/StringConcatTest.dart:49: // TODO(floitsch):
IllegalArgumentException might not be correct.
On 2012/02/15 11:54:49, kasperl wrote:
> Maybe explain this one a bit better? Is the string concatenation operator
> throwing the wrong argument? I guess so.

Done.