Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 9406005: Promote Stephen's InterfaceInheritFieldTest to a language test. (Closed)

Created:
8 years, 10 months ago by kasperl
Modified:
8 years, 10 months ago
Reviewers:
ahe, ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Promote Stephen's InterfaceInheritFieldTest to a language test. Add another test that checks that you can override fields (as spec'ed). R=ngeoffray@google.com,ahe@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=4259

Patch Set 1 #

Patch Set 2 : Improve test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -22 lines) Patch
D frog/tests/frog/src/InterfaceInheritFieldTest.dart View 1 chunk +0 lines, -23 lines 0 comments Download
M tests/language/language.status View 2 chunks +2 lines, -0 lines 0 comments Download
M tests/language/language-leg.status View 1 chunk +1 line, -0 lines 0 comments Download
A + tests/language/src/InterfaceInheritFieldTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A tests/language/src/SuperFieldAccessTest.dart View 1 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kasperl
8 years, 10 months ago (2012-02-15 12:18:54 UTC) #1
ngeoffray
LGTM!
8 years, 10 months ago (2012-02-15 12:27:28 UTC) #2
ahe
8 years, 10 months ago (2012-02-15 13:54:21 UTC) #3
LGTM!

Powered by Google App Engine
This is Rietveld 408576698