Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9405007: Support constructor generation for XSLTProcessor. (Closed)

Created:
8 years, 10 months ago by antonm
Modified:
8 years, 10 months ago
Reviewers:
podivilov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Support constructor generation for XSLTProcessor. BUG=1642 TEST=client/tests/client/dom/XSLTProcessorTest.dart Committed: https://code.google.com/p/dart/source/detail?r=4318

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M client/dom/scripts/dartgenerator.py View 1 chunk +1 line, -1 line 2 comments Download
M client/tests/client/client.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
antonm
8 years, 10 months ago (2012-02-15 16:02:00 UTC) #1
podivilov
http://codereview.chromium.org/9405007/diff/1/client/dom/scripts/dartgenerator.py File client/dom/scripts/dartgenerator.py (right): http://codereview.chromium.org/9405007/diff/1/client/dom/scripts/dartgenerator.py#newcode2711 client/dom/scripts/dartgenerator.py:2711: self._interface.id in ['FileReader', 'WebKitCSSMatrix', 'XSLTProcessor']): Could you please check ...
8 years, 10 months ago (2012-02-15 17:31:03 UTC) #2
antonm
http://codereview.chromium.org/9405007/diff/1/client/dom/scripts/dartgenerator.py File client/dom/scripts/dartgenerator.py (right): http://codereview.chromium.org/9405007/diff/1/client/dom/scripts/dartgenerator.py#newcode2711 client/dom/scripts/dartgenerator.py:2711: self._interface.id in ['FileReader', 'WebKitCSSMatrix', 'XSLTProcessor']): I will, but I ...
8 years, 10 months ago (2012-02-15 18:21:43 UTC) #3
podivilov
8 years, 10 months ago (2012-02-16 10:36:13 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698