Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9401030: remove promise from corelib (Closed)

Created:
8 years, 10 months ago by Siggi Cherem (dart-lang)
Modified:
8 years, 10 months ago
CC:
reviews_dartlang.org, eub, kasperl
Visibility:
Public.

Description

remove promise: - removes promise from corelib (use future instead) - move tests that depend on promises and proxies into samples/proxy/ - remove dependence on promise from the rest of the system and tests Committed: https://code.google.com/p/dart/source/detail?r=4328

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 10

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+341 lines, -3836 lines) Patch
M compiler/lib/corelib.dart View 1 chunk +0 lines, -1 line 0 comments Download
M compiler/lib/corelib_impl.dart View 1 chunk +0 lines, -1 line 0 comments Download
M corelib/src/corelib_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M corelib/src/implementation/corelib_impl_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D corelib/src/implementation/promise_implementation.dart View 1 chunk +0 lines, -379 lines 0 comments Download
D corelib/src/promise.dart View 1 chunk +0 lines, -179 lines 0 comments Download
M frog/leg/scanner/source_list.dart View 2 chunks +0 lines, -3 lines 0 comments Download
M frog/lib/corelib.dart View 1 chunk +0 lines, -1 line 0 comments Download
M frog/lib/corelib_impl.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/snapshot_test.dart View 4 chunks +1 line, -254 lines 0 comments Download
M samples/pond/dart_lib.html View 4 chunks +0 lines, -567 lines 0 comments Download
A samples/proxy/README View 1 1 chunk +17 lines, -0 lines 0 comments Download
A + samples/proxy/promise.dart View 1 1 chunk +178 lines, -2 lines 0 comments Download
M samples/tests/samples/samples.status View 1 3 chunks +5 lines, -1 line 0 comments Download
M samples/tests/samples/src/lib/touch/TouchTest.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + samples/tests/samples/src/proxy/MintMakerFullyIsolated_generatedTest.dart View 1 2 3 3 chunks +29 lines, -16 lines 0 comments Download
A + samples/tests/samples/src/proxy/MintMakerFullyIsolated_testSource.dart View 1 2 3 3 chunks +26 lines, -14 lines 0 comments Download
A + samples/tests/samples/src/proxy/MintMakerPromiseTest.dart View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
A + samples/tests/samples/src/proxy/MintMakerPromiseWithStubs_generatedTest.dart View 1 2 3 2 chunks +30 lines, -16 lines 0 comments Download
A + samples/tests/samples/src/proxy/MintMakerPromiseWithStubs_testSource.dart View 1 2 3 2 chunks +28 lines, -15 lines 0 comments Download
M samples/tests/samples/src/proxy/MintMakerRpcTest.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + samples/tests/samples/src/proxy/PromiseBasedTest.dart View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
A + samples/tests/samples/src/proxy/PromiseTest.dart View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M tests/co19/co19-compiler.status View 1 2 3 5 chunks +4 lines, -40 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 2 3 3 chunks +4 lines, -19 lines 0 comments Download
D tests/corelib/src/PromiseTest.dart View 1 chunk +0 lines, -721 lines 0 comments Download
M tests/isolate/isolate.status View 2 chunks +0 lines, -3 lines 0 comments Download
M tests/isolate/src/MandelIsolateTest.dart View 3 chunks +3 lines, -3 lines 0 comments Download
D tests/isolate/src/MintMakerPromiseTest.dart View 1 chunk +0 lines, -241 lines 0 comments Download
D tests/isolate/src/PromiseBasedTest.dart View 1 chunk +0 lines, -78 lines 0 comments Download
M tests/isolate/src/TestFramework.dart View 3 chunks +1 line, -30 lines 0 comments Download
D tests/stub-generator/src/MintMakerFullyIsolatedTest.dart View 1 chunk +0 lines, -298 lines 0 comments Download
D tests/stub-generator/src/MintMakerFullyIsolatedTest-generatedTest.dart View 1 chunk +0 lines, -508 lines 0 comments Download
D tests/stub-generator/src/MintMakerPromiseWithStubsTest.dart View 1 chunk +0 lines, -129 lines 0 comments Download
D tests/stub-generator/src/MintMakerPromiseWithStubsTest-generatedTest.dart View 1 chunk +0 lines, -255 lines 0 comments Download
D tests/stub-generator/stub-generator.status View 1 chunk +0 lines, -30 lines 0 comments Download
D tests/stub-generator/test_config.dart View 1 chunk +0 lines, -17 lines 0 comments Download
M tools/test.dart View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Siggi Cherem (dart-lang)
This removes Promise from corelib. To keep around the coverage of the mint-maker fully isolated ...
8 years, 10 months ago (2012-02-16 01:36:09 UTC) #1
dgrove
lgtm lgtm! http://codereview.chromium.org/9401030/diff/2004/samples/tests/samples/src/proxy/MintMakerPromiseWithStubs_testSource.dart File samples/tests/samples/src/proxy/MintMakerPromiseWithStubs_testSource.dart (right): http://codereview.chromium.org/9401030/diff/2004/samples/tests/samples/src/proxy/MintMakerPromiseWithStubs_testSource.dart#newcode1 samples/tests/samples/src/proxy/MintMakerPromiseWithStubs_testSource.dart:1: // Copyright (c) 2011, the Dart project ...
8 years, 10 months ago (2012-02-16 03:52:29 UTC) #2
Ivan Posva
Thanks for doing this. -Ivan
8 years, 10 months ago (2012-02-16 08:16:25 UTC) #3
Siggi Cherem (dart-lang)
8 years, 10 months ago (2012-02-16 18:16:11 UTC) #4 
thanks!

https://chromiumcodereview.appspot.com/9401030/diff/2004/samples/tests/sample...
File samples/tests/samples/src/proxy/MintMakerPromiseWithStubs_testSource.dart
(right):

https://chromiumcodereview.appspot.com/9401030/diff/2004/samples/tests/sample...
samples/tests/samples/src/proxy/MintMakerPromiseWithStubs_testSource.dart:1: //
Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
On 2012/02/16 03:52:29, dgrove wrote:
> year

Done.

https://chromiumcodereview.appspot.com/9401030/diff/2004/samples/tests/sample...
File samples/tests/samples/src/proxy/PromiseBasedTest.dart (right):

https://chromiumcodereview.appspot.com/9401030/diff/2004/samples/tests/sample...
samples/tests/samples/src/proxy/PromiseBasedTest.dart:1: // Copyright (c) 2011,
the Dart project authors.  Please see the AUTHORS file
On 2012/02/16 03:52:29, dgrove wrote:
> year

Done.

https://chromiumcodereview.appspot.com/9401030/diff/2004/samples/tests/sample...
File samples/tests/samples/src/proxy/PromiseTest.dart (right):

https://chromiumcodereview.appspot.com/9401030/diff/2004/samples/tests/sample...
samples/tests/samples/src/proxy/PromiseTest.dart:1: // Copyright (c) 2011, the
Dart project authors.  Please see the AUTHORS file
On 2012/02/16 03:52:29, dgrove wrote:
> ditto

Done.

https://chromiumcodereview.appspot.com/9401030/diff/2004/tests/co19/co19-comp...
File tests/co19/co19-compiler.status (right):

https://chromiumcodereview.appspot.com/9401030/diff/2004/tests/co19/co19-comp...
tests/co19/co19-compiler.status:491: LibTest/core/Promise/*: Skip # removed from
corelib
On 2012/02/16 03:52:29, dgrove wrote:
> can you either remove these from co19 or file an issue to have them removed?

Done. Filed a bug.

https://chromiumcodereview.appspot.com/9401030/diff/2004/tests/co19/co19-runt...
File tests/co19/co19-runtime.status (right):

https://chromiumcodereview.appspot.com/9401030/diff/2004/tests/co19/co19-runt...
tests/co19/co19-runtime.status:11: LibTest/core/Promise/*: Skip # removed from
corelib
On 2012/02/16 03:52:29, dgrove wrote:
> same here.

Done.

Powered by Google App Engine
This is Rietveld 408576698