Issue 9398002: - Add tests for the new prefix specifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9398002: - Add tests for the new prefix specifications. (Closed)

Created:
8 years, 10 months ago by siva

Modified:
8 years, 10 months ago

Reviewers:
regis, kasperl, hausner

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/tests/

Visibility:
Public.

More Reviews

Description

- Add tests for the new prefix specifications. - Change a negative test to a positive test as it is valid to now have the same prefix in multiple imports. Committed: https://code.google.com/p/dart/source/detail?r=4290

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -3 lines)			Patch
M	language/language.status	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
A	language/src/Prefix101Test.dart	View	1	1 chunk	+53 lines, -0 lines	0 comments	Download
D	language/src/Prefix3NegativeTest.dart	View	1 2	1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

hausner

LGTM. Might break in frog. http://codereview.chromium.org/9398002/diff/1001/language/src/Prefix3NegativeTest.dart File language/src/Prefix3NegativeTest.dart (right): http://codereview.chromium.org/9398002/diff/1001/language/src/Prefix3NegativeTest.dart#newcode11 language/src/Prefix3NegativeTest.dart:11: #import("library2.dart", prefix: "lib2"); // ...

8 years, 10 months ago (2012-02-14 23:20:47 UTC) #2

siva

Thanks. I have updated 'language.status' to account for potential failures in frog/dartc. http://codereview.chromium.org/9398002/diff/1001/language/src/Prefix3NegativeTest.dart File language/src/Prefix3NegativeTest.dart ...

8 years, 10 months ago (2012-02-14 23:36:01 UTC) #3

Thanks, Siva!

Expand Messages | Collapse Messages