Issue 9395070: Triage Expect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9395070: Triage Expect. (Closed)

Created:
8 years, 10 months ago by ahe

Modified:
8 years, 10 months ago

Reviewers:
ngeoffray, kasperl

CC:
reviews_dartlang.org, karlklose, floitsch, Lasse Reichstein Nielsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Triage Expect. Committed: https://code.google.com/p/dart/source/detail?r=4437

Patch Set 1 #

Total comments: 3

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -29 lines)			Patch
M	dart/frog/leg/lib/js_helper.dart	View	2 chunks	+2 lines, -2 lines	1 comment	Download
M	dart/frog/leg/lib/mockimpl.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/frog/leg/ssa/codegen.dart	View	2 chunks	+10 lines, -3 lines	2 comments	Download
M	dart/tests/co19/co19-leg.status	View	3 chunks	+12 lines, -23 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://chromiumcodereview.appspot.com/9395070/diff/1/dart/frog/leg/lib/js_helper.dart File dart/frog/leg/lib/js_helper.dart (right): https://chromiumcodereview.appspot.com/9395070/diff/1/dart/frog/leg/lib/js_helper.dart#newcode30 dart/frog/leg/lib/js_helper.dart:30: return value !== null && JS("bool", @"$0.constructor === ...

8 years, 10 months ago (2012-02-21 12:23:51 UTC) #3

ahe

8 years, 10 months ago (2012-02-22 09:11:02 UTC) #4

Hi Kasper and Nicolas,

Thank you for your suggestions, I'll address them in a follow-up CL.

Cheers,
Peter

Expand Messages | Collapse Messages