Issue 9392029: futures: add more tests for future and completer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9392029: futures: add more tests for future and completer. (Closed)

Created:
8 years, 10 months ago by Siggi Cherem (dart-lang)

Modified:
8 years, 10 months ago

Reviewers:
mattsh

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

futures: add more tests for future and completer. Committed: https://code.google.com/p/dart/source/detail?r=4231

Patch Set 2 : '' #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+172 lines, -1 line)			Patch
	M	tests/corelib/src/FutureTest.dart	View	1	4 chunks	+172 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mattsh

LGTM. These are really good tests. https://chromiumcodereview.appspot.com/9392029/diff/1/tests/corelib/src/FutureTest.dart File tests/corelib/src/FutureTest.dart (right): https://chromiumcodereview.appspot.com/9392029/diff/1/tests/corelib/src/FutureTest.dart#newcode25 tests/corelib/src/FutureTest.dart:25: } good. https://chromiumcodereview.appspot.com/9392029/diff/1/tests/corelib/src/FutureTest.dart#newcode45 ...

8 years, 10 months ago (2012-02-14 04:21:10 UTC) #2

Siggi Cherem (dart-lang)

8 years, 10 months ago (2012-02-14 16:12:17 UTC) #3

https://chromiumcodereview.appspot.com/9392029/diff/1/tests/corelib/src/Futur...
File tests/corelib/src/FutureTest.dart (right):

https://chromiumcodereview.appspot.com/9392029/diff/1/tests/corelib/src/Futur...
tests/corelib/src/FutureTest.dart:45: int before = null;
On 2012/02/14 04:21:10, mattsh wrote:
> isn't "= null" redundant here (i.e., aren't all variables automatically
> initialized to null?)

True. Fixed.

https://chromiumcodereview.appspot.com/9392029/diff/1/tests/corelib/src/Futur...
tests/corelib/src/FutureTest.dart:127: Expect.isFalse(reached);
On 2012/02/14 04:21:10, mattsh wrote:
> good test

thx

Expand Messages | Collapse Messages

Issue 9392029: futures: add more tests for future and completer. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages