Issue 9392028: Ensure that newly-constructed elements don't have parents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9392028: Ensure that newly-constructed elements don't have parents. (Closed)

Created:
8 years, 10 months ago by nweiz

Modified:
8 years, 10 months ago

Reviewers:
Jacob

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Ensure that newly-constructed elements don't have parents. TBR Committed: https://code.google.com/p/dart/source/detail?r=4206

Patch Set 1 #

Total comments: 1

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -6 lines)			Patch
M	client/html/release/htmlimpl.dart	View	2 chunks	+6 lines, -3 lines	0 comments	Download
M	client/html/src/ElementWrappingImplementation.dart	View	1 chunk	+5 lines, -2 lines	1 comment	Download
M	client/html/src/SVGElementWrappingImplementation.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	client/tests/client/html/ElementTests.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	client/tests/client/html/SVGElementTests.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jacob

8 years, 10 months ago (2012-02-14 02:31:05 UTC) #2

lgtm

thanks for fixing this

https://chromiumcodereview.appspot.com/9392028/diff/1/client/html/src/Element...
File client/html/src/ElementWrappingImplementation.dart (right):

https://chromiumcodereview.appspot.com/9392028/diff/1/client/html/src/Element...
client/html/src/ElementWrappingImplementation.dart:543: var element;
var ==> Element

Expand Messages | Collapse Messages