Issue 9392017: This CL is part of a proposal to change the API of dartc's implementation of UrlSource.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9392017: This CL is part of a proposal to change the API of dartc's implementation of UrlSource. (Closed)

Created:
8 years, 10 months ago by jwren

Modified:
8 years, 10 months ago

Reviewers:
scheglov, danrubel

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

This CL is part of a proposal to change the API of dartc's implementation of UrlSource. Committed: https://code.google.com/p/dart/source/detail?r=4272

Patch Set 1 #

Total comments: 1

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -8 lines)			Patch
M	compiler/java/com/google/dart/compiler/UrlLibrarySource.java	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/UrlSource.java	View	1 chunk	+0 lines, -4 lines	1 comment	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerWarmup.java	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jwren

On 2012/02/13 23:41:38, jwren wrote: Konstantin/Dan- Is this an okay first CL for removing the ...

8 years, 10 months ago (2012-02-14 21:45:21 UTC) #2

scheglov

8 years, 10 months ago (2012-02-15 14:56:40 UTC) #4

LGTM in general.

http://codereview.chromium.org/9392017/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/UrlSource.java (left):

http://codereview.chromium.org/9392017/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/UrlSource.java:119: return uri;
Do we still need "uri" field?

Expand Messages | Collapse Messages