Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 9389002: Ensure FileTest.dart deletes temporary directories (Closed)

Created:
8 years, 10 months ago by Søren Gjesse
Modified:
8 years, 10 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Ensure FileTest.dart deletes temporary directories The FileTest.dart did not delete the created temporary directories. This was caused by the sub-test testOutputStreamWriteAppend not working. The close handler for a file FileOutputStream is newer called. R=ricow@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=4182

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -27 lines) Patch
M tests/standalone/src/FileTest.dart View 9 chunks +25 lines, -27 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
8 years, 10 months ago (2012-02-13 10:44:59 UTC) #1
ricow1
https://chromiumcodereview.appspot.com/9389002/diff/1/tests/standalone/src/FileTest.dart File tests/standalone/src/FileTest.dart (right): https://chromiumcodereview.appspot.com/9389002/diff/1/tests/standalone/src/FileTest.dart#newcode297 tests/standalone/src/FileTest.dart:297: outStream.close(); how do we know that the output has ...
8 years, 10 months ago (2012-02-13 11:40:44 UTC) #2
Søren Gjesse
https://chromiumcodereview.appspot.com/9389002/diff/1/tests/standalone/src/FileTest.dart File tests/standalone/src/FileTest.dart (right): https://chromiumcodereview.appspot.com/9389002/diff/1/tests/standalone/src/FileTest.dart#newcode297 tests/standalone/src/FileTest.dart:297: outStream.close(); On 2012/02/13 11:40:45, ricow1 wrote: > how do ...
8 years, 10 months ago (2012-02-13 11:58:04 UTC) #3
ricow1
8 years, 10 months ago (2012-02-13 11:58:43 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698