Make lists parsed by JSON untyped.

Make lists parsed by JSON untyped.
Committed: https://code.google.com/p/dart/source/detail?r=4219

[Anders Johnsen, 2012-02-13 14:58:29]

Hi Dan,

Can you assign a review for this patch? I'm unsure where to send it.

Thank!

- Anders

[Anders Johnsen, 2012-02-14 09:57:09]

Hi John,

Would you be able to review this patch for me?

Thanks!

- Anders

[antonm, 2012-02-14 12:30:55]

https://chromiumcodereview.appspot.com/9387007/diff/1/lib/json/json.dart
File lib/json/json.dart (right):

https://chromiumcodereview.appspot.com/9387007/diff/1/lib/json/json.dart#newc...
lib/json/json.dart:418: List list = new List();
actually, I wrote this code.

This days I would write it as

final list = [];

or 

var list = [].

And in any way I would do parallel changes to _parseObject code.

BTW, what's the problem you're solving?

[Anders Johnsen, 2012-02-14 12:48:04]

https://chromiumcodereview.appspot.com/9387007/diff/1/lib/json/json.dart
File lib/json/json.dart (right):

https://chromiumcodereview.appspot.com/9387007/diff/1/lib/json/json.dart#newc...
lib/json/json.dart:418: List list = new List();
On 2012/02/14 12:30:55, antonm wrote:
> actually, I wrote this code.
> 
> This days I would write it as
> 
> final list = [];
> 
> or 
> 
> var list = [].
> 
> And in any way I would do parallel changes to _parseObject code.
> 
> BTW, what's the problem you're solving?

I'm fine with "var list = []"!

Right now, the list would be locked to a specific type (Object). If we e.g. send
a List<double>, we want to be able to cast it to that type. List -> List<double>
is fine, but List<Object> -> List<double> is not. Okay with you?

[antonm, 2012-02-14 13:04:06]

https://chromiumcodereview.appspot.com/9387007/diff/1/lib/json/json.dart
File lib/json/json.dart (right):

https://chromiumcodereview.appspot.com/9387007/diff/1/lib/json/json.dart#newc...
lib/json/json.dart:418: List list = new List();
On 2012/02/14 12:48:04, ajohnsen wrote:
> On 2012/02/14 12:30:55, antonm wrote:
> > actually, I wrote this code.
> > 
> > This days I would write it as
> > 
> > final list = [];
> > 
> > or 
> > 
> > var list = [].
> > 
> > And in any way I would do parallel changes to _parseObject code.
> > 
> > BTW, what's the problem you're solving?
> 
> I'm fine with "var list = []"!
> 
> Right now, the list would be locked to a specific type (Object). If we e.g.
send
> a List<double>, we want to be able to cast it to that type. List ->
List<double>
> is fine, but List<Object> -> List<double> is not. Okay with you?

I too prefer []/{}, but curious: I thought that List<double> should be ok here
as Object should be supertype of double as well.

BTW, I think overall, in this code final is preferred over var.

[Anders Johnsen, 2012-02-14 13:13:14]

https://chromiumcodereview.appspot.com/9387007/diff/1/lib/json/json.dart
File lib/json/json.dart (right):

https://chromiumcodereview.appspot.com/9387007/diff/1/lib/json/json.dart#newc...
lib/json/json.dart:418: List list = new List();
On 2012/02/14 13:04:06, antonm wrote:
> On 2012/02/14 12:48:04, ajohnsen wrote:
> > On 2012/02/14 12:30:55, antonm wrote:
> > > actually, I wrote this code.
> > > 
> > > This days I would write it as
> > > 
> > > final list = [];
> > > 
> > > or 
> > > 
> > > var list = [].
> > > 
> > > And in any way I would do parallel changes to _parseObject code.
> > > 
> > > BTW, what's the problem you're solving?
> > 
> > I'm fine with "var list = []"!
> > 
> > Right now, the list would be locked to a specific type (Object). If we e.g.
> send
> > a List<double>, we want to be able to cast it to that type. List ->
> List<double>
> > is fine, but List<Object> -> List<double> is not. Okay with you?
> 
> I too prefer []/{}, but curious: I thought that List<double> should be ok here
> as Object should be supertype of double as well.
> 
> BTW, I think overall, in this code final is preferred over var.

List<double> myList = fromJson["list"]; // of type List<Object>

Here Object is to generic to be assignable to double. (Sorry if I was unclear
before). The other way around should not be a problem, but that is not the
problem I'm having. I've updated the patch. I agree with final being better.

Thanks!

[antonm, 2012-02-14 13:41:54]

LGTM!