First exercise of spawnUri. Enabling the test needs issue 1666, but hand-running the test (copyi...

First exercise of spawnUri.  Enabling the test needs issue 1666, but hand-running the test (copying and editing all necessary output files into the right structure) succeeds.
Committed: https://code.google.com/p/dart/source/detail?r=4287

[Siggi Cherem (dart-lang), 2012-02-14 01:16:46]

thanks Eli!

some minor comments...

https://chromiumcodereview.appspot.com/9386027/diff/1/tests/isolate/isolate.s...
File tests/isolate/isolate.status (right):

https://chromiumcodereview.appspot.com/9386027/diff/1/tests/isolate/isolate.s...
tests/isolate/isolate.status:44: # will have APIv2_spawnUriBrowserNegativeTest:
Fail
test.dart will automatically assume that *NegativeTest must fail.

https://chromiumcodereview.appspot.com/9386027/diff/1/tests/isolate/src/APIv2...
File tests/isolate/src/APIv2_spawnUriBrowserNegativeTest.dart (right):

https://chromiumcodereview.appspot.com/9386027/diff/1/tests/isolate/src/APIv2...
tests/isolate/src/APIv2_spawnUriBrowserNegativeTest.dart:11: asyncTest("message
- reply chain", 1, () {
let's indicate in the message that this is for spawnUri, e.g. 'spawnUri,
message, and reply' (we should probably make the spawnCode test description more
specific too)

https://chromiumcodereview.appspot.com/9386027/diff/1/tests/isolate/src/APIv2...
File tests/isolate/src/APIv2_spawnUriChildIsolate.dart (right):

https://chromiumcodereview.appspot.com/9386027/diff/1/tests/isolate/src/APIv2...
tests/isolate/src/APIv2_spawnUriChildIsolate.dart:11: // just for frog's sake.
+ TODO

[eub, 2012-02-15 19:58:22]

Thanks, PTAL?

https://chromiumcodereview.appspot.com/9386027/diff/1/tests/isolate/isolate.s...
File tests/isolate/isolate.status (right):

https://chromiumcodereview.appspot.com/9386027/diff/1/tests/isolate/isolate.s...
tests/isolate/isolate.status:44: # will have APIv2_spawnUriBrowserNegativeTest:
Fail
On 2012/02/14 01:16:46, sigmund wrote:
> test.dart will automatically assume that *NegativeTest must fail.

Done.

https://chromiumcodereview.appspot.com/9386027/diff/1/tests/isolate/src/APIv2...
File tests/isolate/src/APIv2_spawnUriBrowserNegativeTest.dart (right):

https://chromiumcodereview.appspot.com/9386027/diff/1/tests/isolate/src/APIv2...
tests/isolate/src/APIv2_spawnUriBrowserNegativeTest.dart:11: asyncTest("message
- reply chain", 1, () {
On 2012/02/14 01:16:46, sigmund wrote:
> let's indicate in the message that this is for spawnUri, e.g. 'spawnUri,
> message, and reply' (we should probably make the spawnCode test description
more
> specific too)

How's this?

https://chromiumcodereview.appspot.com/9386027/diff/1/tests/isolate/src/APIv2...
File tests/isolate/src/APIv2_spawnUriChildIsolate.dart (right):

https://chromiumcodereview.appspot.com/9386027/diff/1/tests/isolate/src/APIv2...
tests/isolate/src/APIv2_spawnUriChildIsolate.dart:11: // just for frog's sake.
On 2012/02/14 01:16:46, sigmund wrote:
> + TODO

Done.

[Siggi Cherem (dart-lang), 2012-02-15 20:00:13]

lgtm