Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 9382041: Support getting of static functions. (Closed)

Created:
8 years, 10 months ago by floitsch
Modified:
8 years, 10 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Support getting of static functions. Example: class A { foo() => 499; } main() { ... var f = A.foo; ... f(); } Implemented by using the static function as container for the closure call methods. In JS: <foo> = function() { return 499; } <foo>.call$0 = <foo>; // If necessary add stubs for named arguments on <foo> too. Committed: https://code.google.com/p/dart/source/detail?r=4184

Patch Set 1 #

Total comments: 4

Patch Set 2 : Update comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -4 lines) Patch
M frog/leg/compiler.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M frog/leg/emitter.dart View 1 2 chunks +23 lines, -0 lines 0 comments Download
M frog/leg/lib/core.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M frog/leg/ssa/builder.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M frog/leg/universe.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/co19/co19-leg.status View 1 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language-leg.status View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
floitsch
Tests are coming on Monday. https://chromiumcodereview.appspot.com/9382041/diff/1/frog/leg/universe.dart File frog/leg/universe.dart (right): https://chromiumcodereview.appspot.com/9382041/diff/1/frog/leg/universe.dart#newcode11 frog/leg/universe.dart:11: // example the number ...
8 years, 10 months ago (2012-02-12 20:43:11 UTC) #1
ngeoffray
LGTM! https://chromiumcodereview.appspot.com/9382041/diff/1/frog/leg/emitter.dart File frog/leg/emitter.dart (right): https://chromiumcodereview.appspot.com/9382041/diff/1/frog/leg/emitter.dart#newcode273 frog/leg/emitter.dart:273: FunctionElement callElement = Please explain why you need ...
8 years, 10 months ago (2012-02-13 10:21:52 UTC) #2
floitsch
8 years, 10 months ago (2012-02-13 12:34:02 UTC) #3
https://chromiumcodereview.appspot.com/9382041/diff/1/frog/leg/emitter.dart
File frog/leg/emitter.dart (right):

https://chromiumcodereview.appspot.com/9382041/diff/1/frog/leg/emitter.dart#n...
frog/leg/emitter.dart:273: FunctionElement callElement =
On 2012/02/13 10:21:52, ngeoffray wrote:
> Please explain why you need to create a temporary element.

Done.

Powered by Google App Engine
This is Rietveld 408576698