Issue 9382001: Another attempt at fixing the Socket tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9382001: Another attempt at fixing the Socket tests. (Closed)

Created:
8 years, 10 months ago by Mads Ager (google)

Modified:
8 years, 10 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Another attempt at fixing the Socket tests. The tests did not wait for the server isolate to finish before exiting the main isolate. The tests did not correctly count the number of bytes received on the server-side. We have to count bytes per connection. There were issues with close handlers being confused for timeouts. R=sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=4127

Patch Set 1 #

Total comments: 1

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+243 lines, -104 lines)			Patch
M	runtime/bin/socket_impl.dart	View	4 chunks	+23 lines, -16 lines	0 comments	Download
M	runtime/bin/socket_stream_impl.dart	View	4 chunks	+4 lines, -6 lines	1 comment	Download
M	tests/standalone/src/SocketCloseTest.dart	View	13 chunks	+77 lines, -35 lines	0 comments	Download
M	tests/standalone/src/SocketStreamCloseTest.dart	View	15 chunks	+139 lines, -47 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

8 years, 10 months ago (2012-02-10 10:44:33 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/9382001/diff/1/runtime/bin/socket_stre...
File runtime/bin/socket_stream_impl.dart (left):

https://chromiumcodereview.appspot.com/9382001/diff/1/runtime/bin/socket_stre...
runtime/bin/socket_stream_impl.dart:123: void set closeHandler(void callback())
{
We still have a closeHandler setter int the OutputStream interface. Maybe we
should leave this here for now. We have
http://code.google.com/p/dart/issues/detail?id=941 open on this issue.

Expand Messages | Collapse Messages