Use package names as import prefixes when generating code

Use package names as import prefixes when generating code

The generated code does not include the package name in the generated
top-level classes. If several packages have the same class this causes
conflicts. This change will add a prefix for each import in the
generated file to solve this. The prefix used is the package name.

R=sigmund@google.com
BUG=https://github.com/dart-lang/dart-protobuf/issues/12

Committed: https://github.com/dart-lang/protoc-plugin/commit/24f06a2

[Siggi Cherem (dart-lang), 2013-12-20 18:27:36]

lgtm, minor comments below.

https://chromiumcodereview.appspot.com/93743006/diff/1/lib/file_generator.dart
File lib/file_generator.dart (right):

https://chromiumcodereview.appspot.com/93743006/diff/1/lib/file_generator.dar...
lib/file_generator.dart:135: out.println("import
'${_generatedFilePath(relativeProtoPath)}'");
remove new line

https://chromiumcodereview.appspot.com/93743006/diff/1/lib/file_generator.dar...
lib/file_generator.dart:137: out.println(' as ${fileGenerator.package}');
and here? (println -> print)?

https://chromiumcodereview.appspot.com/93743006/diff/1/lib/protobuf_field.dart
File lib/protobuf_field.dart (right):

https://chromiumcodereview.appspot.com/93743006/diff/1/lib/protobuf_field.dar...
lib/protobuf_field.dart:21: final String fqname;
I know this is unrelated, but what does 'fqname' stand for?

https://chromiumcodereview.appspot.com/93743006/diff/1/lib/protobuf_field.dar...
lib/protobuf_field.dart:25: final String prefixedBaseType;
should we make these getters instead?

[Søren Gjesse, 2014-01-02 08:52:32]

https://codereview.chromium.org/93743006/diff/1/lib/file_generator.dart
File lib/file_generator.dart (right):

https://codereview.chromium.org/93743006/diff/1/lib/file_generator.dart#newco...
lib/file_generator.dart:135: out.println("import
'${_generatedFilePath(relativeProtoPath)}'");
On 2013/12/20 18:27:36, Siggi Cherem (dart-lang) wrote:
> remove new line

Done.

https://codereview.chromium.org/93743006/diff/1/lib/file_generator.dart#newco...
lib/file_generator.dart:137: out.println(' as ${fileGenerator.package}');
On 2013/12/20 18:27:36, Siggi Cherem (dart-lang) wrote:
> and here? (println -> print)?

Done.

https://codereview.chromium.org/93743006/diff/1/lib/protobuf_field.dart
File lib/protobuf_field.dart (right):

https://codereview.chromium.org/93743006/diff/1/lib/protobuf_field.dart#newco...
lib/protobuf_field.dart:21: final String fqname;
On 2013/12/20 18:27:36, Siggi Cherem (dart-lang) wrote:
> I know this is unrelated, but what does 'fqname' stand for?

fqname is the "fully qualified name", that is the field name prefixed by the
fqname of the class. The fqname of the class is the class name prefoxed by a .
and the package name (if any).

https://codereview.chromium.org/93743006/diff/1/lib/protobuf_field.dart#newco...
lib/protobuf_field.dart:25: final String prefixedBaseType;
On 2013/12/20 18:27:36, Siggi Cherem (dart-lang) wrote:
> should we make these getters instead?

I decided to keep the current structure of final fields for this change. We
should consider changing most of these finals to getters.

[Søren Gjesse, 2014-01-02 08:56:40]

Committed patchset #2 manually as r24f06a2 (presubmit successful).

[Siggi Cherem (dart-lang), 2014-01-02 18:29:46]

https://codereview.chromium.org/93743006/diff/1/lib/protobuf_field.dart
File lib/protobuf_field.dart (right):

https://codereview.chromium.org/93743006/diff/1/lib/protobuf_field.dart#newco...
lib/protobuf_field.dart:21: final String fqname;
On 2014/01/02 08:52:33, Søren Gjesse wrote:
> On 2013/12/20 18:27:36, Siggi Cherem (dart-lang) wrote:
> > I know this is unrelated, but what does 'fqname' stand for?
> 
> fqname is the "fully qualified name", that is the field name prefixed by the
> fqname of the class. The fqname of the class is the class name prefoxed by a .
> and the package name (if any).

I see, thanks for the clarification!

I think renaming this to qualifiedName or something similar would totally be
worth it in the future.