Issue 9373043: Move helpers and interceptors to own library.

Issue 9373043: Move helpers and interceptors to own library. (Closed)

Created:
8 years, 10 months ago by ahe

Modified:
8 years, 10 months ago

Reviewers:
floitsch, ngeoffray

CC:
reviews_dartlang.org, kasperl, Lasse Reichstein Nielsen, karlklose

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Move helpers and interceptors to own library. Committed: https://code.google.com/p/dart/source/detail?r=4229

Patch Set 2 : Add TODO #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -490 lines)			Patch
M	dart/frog/leg/compiler.dart	View	1	4 chunks	+22 lines, -12 lines	0 comments	Download
M	dart/frog/leg/lib/core.dart	View		3 chunks	+8 lines, -296 lines	0 comments	Download
A	dart/frog/leg/lib/coreimpl.dart	View		1 chunk	+6 lines, -0 lines	0 comments	Download
A +	dart/frog/leg/lib/js_helper.dart	View		2 chunks	+4 lines, -162 lines	0 comments	Download
M	dart/frog/leg/scanner/scanner_task.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dart/frog/leg/ssa/builder.dart	View		1 chunk	+8 lines, -8 lines	0 comments	Download
M	dart/frog/leg/typechecker.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	dart/frog/tests/leg/src/mock_compiler.dart	View		4 chunks	+12 lines, -5 lines	0 comments	Download
M	dart/tests/language/language-leg.status	View		6 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

https://chromiumcodereview.appspot.com/9373043/diff/1/dart/frog/leg/compiler.dart File dart/frog/leg/compiler.dart (right): https://chromiumcodereview.appspot.com/9373043/diff/1/dart/frog/leg/compiler.dart#newcode159 dart/frog/leg/compiler.dart:159: const SourceString('JS_HAS_EQUALS'), library), this); We're defining those guys in ...

8 years, 10 months ago (2012-02-10 08:51:44 UTC) #2

ahe

8 years, 10 months ago (2012-02-14 12:55:26 UTC) #4

Thank you, Nicolas and Florian!

https://chromiumcodereview.appspot.com/9373043/diff/1/dart/frog/leg/compiler....
File dart/frog/leg/compiler.dart (right):

https://chromiumcodereview.appspot.com/9373043/diff/1/dart/frog/leg/compiler....
dart/frog/leg/compiler.dart:159: const SourceString('JS_HAS_EQUALS'), library),
this);
On 2012/02/10 08:51:44, ngeoffray wrote:
> We're defining those guys in all (core, coreimpl, helper) libraries, and I
don't
> think that's what we want. Can't you just define them in helper?

It's not immediately obvious how to do so. I'll try to land this change and
discuss this with you in person. For now, I'm adding a TODO.

Expand Messages | Collapse Messages