Issue 9373019: Frog shouldn't read libraries with --leg_only.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9373019: Frog shouldn't read libraries with --leg_only. (Closed)

Created:
8 years, 10 months ago by ahe

Modified:
8 years, 10 months ago

Reviewers:
ngeoffray, kasperl

CC:
reviews_dartlang.org, ngeoffray, Lasse Reichstein Nielsen, karlklose, floitsch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Frog shouldn't read libraries with --leg_only. Also, simplify leg options. Also, don't print Frog specific messages when running leg. Committed: https://code.google.com/p/dart/source/detail?r=4074

Patch Set 1 #

Total comments: 2

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -17 lines)			Patch
M	dart/frog/frog_options.dart	View	2 chunks	+1 line, -5 lines	2 comments	Download
M	dart/frog/tests/leg_only/leg_only.status	View	1 chunk	+7 lines, -3 lines	0 comments	Download
M	dart/frog/tests/leg_only/test_config.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	dart/frog/world.dart	View	5 chunks	+10 lines, -5 lines	0 comments	Download
M	dart/tools/testing/dart/test_suite.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://chromiumcodereview.appspot.com/9373019/diff/1/dart/frog/frog_options.dart File dart/frog/frog_options.dart (right): https://chromiumcodereview.appspot.com/9373019/diff/1/dart/frog/frog_options.dart#newcode85 dart/frog/frog_options.dart:85: case '--leg': Should we remove the other flags?

8 years, 10 months ago (2012-02-09 09:14:21 UTC) #2

ahe

8 years, 10 months ago (2012-02-09 10:05:32 UTC) #4

Kasper and Nicolas,

Thank you for you comments.

Cheers,
Peter

https://chromiumcodereview.appspot.com/9373019/diff/1/dart/frog/frog_options....
File dart/frog/frog_options.dart (right):

https://chromiumcodereview.appspot.com/9373019/diff/1/dart/frog/frog_options....
dart/frog/frog_options.dart:85: case '--leg':
On 2012/02/09 09:14:21, ngeoffray wrote:
> Should we remove the other flags?

In a few days. Right now we have an open VM bug that uses these options.

Expand Messages | Collapse Messages