Issue 9372107: A return and a throw should empty the environment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9372107: A return and a throw should empty the environment. (Closed)

Created:
8 years, 10 months ago by ngeoffray

Modified:
8 years, 10 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, ahe, karlklose, Lasse Reichstein Nielsen, kasperl

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

A return and a throw should empty the environment. Committed: https://code.google.com/p/dart/source/detail?r=4518

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -4 lines)			Patch
	M	frog/leg/ssa/bailout.dart	View	1	3 chunks	+13 lines, -4 lines	0 comments	Download
	A	tests/language/src/ReturnInLoopTest.dart	View		1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

floitsch

8 years, 10 months ago (2012-02-22 17:22:32 UTC) #2

LGTM.

https://chromiumcodereview.appspot.com/9372107/diff/2001/frog/leg/ssa/bailout...
File frog/leg/ssa/bailout.dart (left):

https://chromiumcodereview.appspot.com/9372107/diff/2001/frog/leg/ssa/bailout...
frog/leg/ssa/bailout.dart:40: remove(instruction);
keep.

Expand Messages | Collapse Messages