Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9372078: Fix for 1267: Implement (partially) Math.pow for integers. (Closed)

Created:
8 years, 10 months ago by srdjan
Modified:
8 years, 10 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix for 1267: Implement (partially) Math.pow for integers. Committed: https://code.google.com/p/dart/source/detail?r=4419

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M runtime/lib/integers.dart View 1 2 chunks +10 lines, -1 line 0 comments Download
M tests/co19/co19-runtime.status View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
8 years, 10 months ago (2012-02-21 22:33:07 UTC) #1
siva
lgtm https://chromiumcodereview.appspot.com/9372078/diff/1/runtime/lib/integers.dart File runtime/lib/integers.dart (right): https://chromiumcodereview.appspot.com/9372078/diff/1/runtime/lib/integers.dart#newcode121 runtime/lib/integers.dart:121: double res = this.toDouble().pow(exponent); our Bigint to double ...
8 years, 10 months ago (2012-02-22 01:10:43 UTC) #2
srdjan
8 years, 10 months ago (2012-02-22 01:38:59 UTC) #3 
https://chromiumcodereview.appspot.com/9372078/diff/1/runtime/lib/integers.dart
File runtime/lib/integers.dart (right):

https://chromiumcodereview.appspot.com/9372078/diff/1/runtime/lib/integers.da...
runtime/lib/integers.dart:121: double res = this.toDouble().pow(exponent);
On 2012/02/22 01:10:43, asiva wrote:
> our Bigint to double conversion is not implemented correctly and I am not sure
> this would work for that case. Maybe instead you could throw an unimplemented
> exception if 'this' is a bigint.

Done.

Powered by Google App Engine
This is Rietveld 408576698