Issue 9370020: Fully support try/catch.

Issue 9370020: Fully support try/catch. (Closed)

Created:
8 years, 10 months ago by ngeoffray

Modified:
8 years, 10 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, kasperl, ahe, karlklose, Lasse Reichstein Nielsen

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fully support try/catch. Committed: https://code.google.com/p/dart/source/detail?r=4084

Patch Set 3 : '' #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -47 lines)			Patch
M	frog/leg/ssa/builder.dart	View	1 2	5 chunks	+59 lines, -15 lines	0 comments	Download
M	frog/leg/ssa/codegen.dart	View	1 2	2 chunks	+10 lines, -12 lines	0 comments	Download
M	frog/leg/ssa/nodes.dart	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/co19/co19-leg.status	View	1 2	4 chunks	+2 lines, -17 lines	0 comments	Download
M	tests/language/language-leg.status	View	1 2	2 chunks	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://chromiumcodereview.appspot.com/9370020/diff/1/frog/leg/ssa/builder.dart File frog/leg/ssa/builder.dart (right): https://chromiumcodereview.appspot.com/9370020/diff/1/frog/leg/ssa/builder.dart#newcode1841 frog/leg/ssa/builder.dart:1841: const SourceString(''), ElementKind.PARAMETER, work.element); I would still give ...

8 years, 10 months ago (2012-02-09 15:06:56 UTC) #2

ngeoffray

8 years, 10 months ago (2012-02-09 15:13:48 UTC) #3

Thanks Florian!

https://chromiumcodereview.appspot.com/9370020/diff/1/frog/leg/ssa/builder.dart
File frog/leg/ssa/builder.dart (right):

https://chromiumcodereview.appspot.com/9370020/diff/1/frog/leg/ssa/builder.da...
frog/leg/ssa/builder.dart:1841: const SourceString(''), ElementKind.PARAMETER,
work.element);
On 2012/02/09 15:06:57, floitsch wrote:
> I would still give it a name.

Done.

https://chromiumcodereview.appspot.com/9370020/diff/1/frog/leg/ssa/builder.da...
frog/leg/ssa/builder.dart:1857: condition = new HIs(elements[declaration.type],
exception);
On 2012/02/09 15:06:57, floitsch wrote:
> element

Done.

https://chromiumcodereview.appspot.com/9370020/diff/1/frog/leg/ssa/builder.da...
frog/leg/ssa/builder.dart:1872: visitElse = () {
On 2012/02/09 15:06:57, floitsch wrote:
> void visitElse() { ...

Done.

https://chromiumcodereview.appspot.com/9370020/diff/1/frog/leg/ssa/codegen.dart
File frog/leg/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/9370020/diff/1/frog/leg/ssa/codegen.da...
frog/leg/ssa/codegen.dart:361: indent--;
On 2012/02/09 15:06:57, floitsch wrote:
> add comment that this is the catch part.

Done.

https://chromiumcodereview.appspot.com/9370020/diff/1/frog/leg/ssa/codegen.da...
frog/leg/ssa/codegen.dart:361: indent--;
On 2012/02/09 15:06:57, floitsch wrote:
> I would move the indent-- out of the if.

Done.

Expand Messages | Collapse Messages