Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 9369062: Ensure 'raises' clauses on operations are saved in IDL database. (Closed)

Created:
8 years, 10 months ago by sra1
Modified:
8 years, 10 months ago
Reviewers:
podivilov1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Ensure 'raises' clauses on operations are saved in IDL database. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=4117

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M client/dom/scripts/dartgenerator.py View 2 chunks +19 lines, -0 lines 0 comments Download
M client/dom/scripts/fremontcutbuilder.py View 1 chunk +4 lines, -0 lines 0 comments Download
M client/dom/scripts/idlrenderer.py View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
sra1
Hi Pavel, You made a similar change to support exceptions on attribute getters and setters. ...
8 years, 10 months ago (2012-02-10 06:17:42 UTC) #1
sra1
tbr
8 years, 10 months ago (2012-02-10 06:19:10 UTC) #2
podivilov
8 years, 10 months ago (2012-02-10 14:01:31 UTC) #3
LGTM.

On 2012/02/10 06:17:42, sra1 wrote:
> Hi Pavel,
> 
> You made a similar change to support exceptions on attribute getters and
> setters.
> I want the information in order to mark the DOM exception types as possibly
> entering Dart code via raised exceptions.
> Do you know from your work in the C++ generator(s) if this information is at
all
> accurate?  I suspect it is not 100% accurate because of the typos indicate the
> name is unused by the generator, but is there some minimum I can assume, e.g.
> operations without a raise clause throw only the regular JS exceptions like
> TypeError?

Presence of raises keyword indicates that webcore implementation takes
additional ExceptionCode parameter which is converted to DOMException by
generated bindings in case of failure. It is 100% accurate because otherwise c++
code won't even compile. And yes, operations without a raise could only raise
TypeError.

AFAIK exception name doesn't mean anything, which explains the typos. I also
faced this problem when generating native bindings with dartgenerator.py, we
need to fix it upstream.

Powered by Google App Engine
This is Rietveld 408576698