Issue 9369010: repurpose dart_client bots for browser testing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9369010: repurpose dart_client bots for browser testing (Closed)

Created:
8 years, 10 months ago by Jennifer Messerly

Modified:
8 years, 10 months ago

Reviewers:
Siggi Cherem (dart-lang), Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

repurpose dart_client bots for browser testing I also refactored the buildbot_annotated_steps in client to remove the now-dead code. Committed: https://code.google.com/p/dart/source/detail?r=4057

Patch Set 2 : fixed comment #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -100 lines)			Patch
	M	client/tools/buildbot_annotated_steps.py	View		5 chunks	+8 lines, -72 lines	0 comments	Download
	M	frog/scripts/buildbot_annotated_steps.py	View	1	5 chunks	+42 lines, -28 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

I tested this locally by setting out my "builder name" to either be like the ...

8 years, 10 months ago (2012-02-09 01:02:54 UTC) #1

Siggi Cherem (dart-lang)

lgtm https://chromiumcodereview.appspot.com/9369010/diff/1/frog/scripts/buildbot_annotated_steps.py File frog/scripts/buildbot_annotated_steps.py (right): https://chromiumcodereview.appspot.com/9369010/diff/1/frog/scripts/buildbot_annotated_steps.py#newcode148 frog/scripts/buildbot_annotated_steps.py:148: # we don't have this translation step. +bug ...

8 years, 10 months ago (2012-02-09 01:16:07 UTC) #2

lgtm!

Expand Messages | Collapse Messages

Issue 9369010: repurpose dart_client bots for browser testing (Closed)

Description

Patch Set 1 #

Patch Set 2 : fixed comment #

Messages