Issue 9368033: Support is checks on primitive types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9368033: Support is checks on primitive types. (Closed)

Created:
8 years, 10 months ago by ngeoffray

Modified:
8 years, 10 months ago

Reviewers:
ahe, floitsch

CC:
reviews_dartlang.org, karlklose, Lasse Reichstein Nielsen, ahe, kasperl

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Support is checks on primitive types. Committed: https://code.google.com/p/dart/source/detail?r=4124

Patch Set 2 : '' #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+108 lines, -76 lines)			Patch
M	dart/frog/leg/lib/core.dart	View	1	9 chunks	+12 lines, -15 lines	0 comments	Download
M	dart/frog/leg/resolver.dart	View	1	1 chunk	+1 line, -8 lines	0 comments	Download
M	dart/frog/leg/ssa/codegen.dart	View	1	2 chunks	+74 lines, -32 lines	0 comments	Download
M	dart/frog/leg/ssa/codegen_helpers.dart	View	1	4 chunks	+18 lines, -7 lines	0 comments	Download
M	dart/tests/co19/co19-leg.status	View	1	8 chunks	+1 line, -13 lines	0 comments	Download
M	dart/tests/language/language-leg.status	View	1	3 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://chromiumcodereview.appspot.com/9368033/diff/2001/dart/frog/leg/ssa/codegen_helpers.dart File dart/frog/leg/ssa/codegen_helpers.dart (right): https://chromiumcodereview.appspot.com/9368033/diff/2001/dart/frog/leg/ssa/codegen_helpers.dart#newcode37 dart/frog/leg/ssa/codegen_helpers.dart:37: void visitIs(HIs instruction) {} add comment why this ...

8 years, 10 months ago (2012-02-10 09:38:17 UTC) #3

ngeoffray

8 years, 10 months ago (2012-02-10 09:40:48 UTC) #4

Thanks Peter and Florian

https://chromiumcodereview.appspot.com/9368033/diff/2001/dart/frog/leg/ssa/co...
File dart/frog/leg/ssa/codegen_helpers.dart (right):

https://chromiumcodereview.appspot.com/9368033/diff/2001/dart/frog/leg/ssa/co...
dart/frog/leg/ssa/codegen_helpers.dart:37: void visitIs(HIs instruction) {}
On 2012/02/10 09:38:17, floitsch wrote:
> add comment why this is empty.

Done.

Expand Messages | Collapse Messages

Issue 9368033: Support is checks on primitive types. (Closed)

Description

Patch Set 1 : '' #

Patch Set 2 : '' #

Messages