Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 9368032: Represent declared type parameters of a class as an array of TypeParameter (Closed)

Created:
8 years, 10 months ago by regis
Modified:
8 years, 10 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Represent declared type parameters of a class as an array of TypeParameter rather than an array of String and simplify code accordingly. Rename the field holding type parameter bounds of a class. Note: I retract my earlier suggestion to Srdjan to represent interfaces of a class (as well as its canonical types) as a TypeArguments. This would require more code to check for an empty array and for growing the array. Besides, these are really arrays and have nothing to do with type arguments. I removed the corresponding TODO(srdjan). Committed: https://code.google.com/p/dart/source/detail?r=4096

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -177 lines) Patch
M runtime/vm/class_finalizer.cc View 5 chunks +43 lines, -69 lines 0 comments Download
M runtime/vm/object.h View 4 chunks +11 lines, -16 lines 0 comments Download
M runtime/vm/object.cc View 13 chunks +43 lines, -53 lines 0 comments Download
M runtime/vm/parser.cc View 5 chunks +31 lines, -35 lines 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
Hi Matthias :-) I'm back (kind of). Thanks, Regis
8 years, 10 months ago (2012-02-09 17:23:44 UTC) #1
hausner
Welcome back. LGTM.
8 years, 10 months ago (2012-02-09 21:24:47 UTC) #2
regis
8 years, 10 months ago (2012-02-09 21:29:24 UTC) #3
Thanks!

Powered by Google App Engine
This is Rietveld 408576698