Implement capability to use the same library prefix for multiple library imports (currently this ...

Implement capability to use the same library prefix for multiple library imports (currently this is flagged as an error).

e.g:

#import("mylib101.dart", prefix:"mylib");
#import("mylib102.dart", prefix:"mylib");
#import("mylib103.dart", prefix:"mylib");
Committed: https://code.google.com/p/dart/source/detail?r=4289

[siva, 2012-02-15 02:14:25]

synched up with latest changes from Regis.

[hausner, 2012-02-15 18:04:26]

LGTM.

http://codereview.chromium.org/9363048/diff/7002/vm/object.cc
File vm/object.cc (right):

http://codereview.chromium.org/9363048/diff/7002/vm/object.cc#newcode4779
vm/object.cc:4779: libs.SetAt(num_current_libs, library);
If you handle the case of growing the array first, the SetAt can be factored out
into a common path.

http://codereview.chromium.org/9363048/diff/7002/vm/parser.cc
File vm/parser.cc (right):

http://codereview.chromium.org/9363048/diff/7002/vm/parser.cc#newcode6520
vm/parser.cc:6520: Function& func = Function::Handle();
Why not allocate a ZoneHandle here instead of allocating a second handle a few
lines below?

[regis, 2012-02-15 18:39:47]

LGTM

http://codereview.chromium.org/9363048/diff/7002/vm/parser.cc
File vm/parser.cc (right):

http://codereview.chromium.org/9363048/diff/7002/vm/parser.cc#newcode6194
vm/parser.cc:6194: resolved_type_class =
lib_prefix.LookupLocalClass(unresolved_class_name);
Nice cleanup!

[siva, 2012-02-15 20:52:47]

Thanks.

http://codereview.chromium.org/9363048/diff/7002/vm/object.cc
File vm/object.cc (right):

http://codereview.chromium.org/9363048/diff/7002/vm/object.cc#newcode4779
vm/object.cc:4779: libs.SetAt(num_current_libs, library);
Good point.

Restructured as suggested.

On 2012/02/15 18:04:27, hausner wrote:
> If you handle the case of growing the array first, the SetAt can be factored
out
> into a common path.

http://codereview.chromium.org/9363048/diff/7002/vm/parser.cc
File vm/parser.cc (right):

http://codereview.chromium.org/9363048/diff/7002/vm/parser.cc#newcode6194
vm/parser.cc:6194: resolved_type_class =
lib_prefix.LookupLocalClass(unresolved_class_name);
On 2012/02/15 18:39:48, regis wrote:
> Nice cleanup!

Thanks.

http://codereview.chromium.org/9363048/diff/7002/vm/parser.cc#newcode6520
vm/parser.cc:6520: Function& func = Function::Handle();
On 2012/02/15 18:04:27, hausner wrote:
> Why not allocate a ZoneHandle here instead of allocating a second handle a few
> lines below?

Hoisted the Handle allocation outside the 'if statement' the
way it used to be.

[kasperl, 2012-02-16 05:47:44]

Thanks, Siva. This is cool stuff. I expect we do not have any tests for this
feature?