Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 9363039: Disable all thread pool tests on Windows (Closed)

Created:
8 years, 10 months ago by Søren Gjesse
Modified:
8 years, 10 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Disable all thread pool tests on Windows The thread pool is actually implemented on Windows, but the current monitor implementation has some know issues. R=ricow@google.com BUG=dart:1673 TEST= Committed: https://code.google.com/p/dart/source/detail?r=4208

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M runtime/tests/vm/vm.status View 1 chunk +4 lines, -2 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
8 years, 10 months ago (2012-02-14 08:40:36 UTC) #1
ricow1
https://chromiumcodereview.appspot.com/9363039/diff/1/runtime/tests/vm/vm.status File runtime/tests/vm/vm.status (right): https://chromiumcodereview.appspot.com/9363039/diff/1/runtime/tests/vm/vm.status#newcode12 runtime/tests/vm/vm.status:12: ThreadPoolstartStop: Skip Unintentional edit?
8 years, 10 months ago (2012-02-14 08:51:58 UTC) #2
ricow1
LGTM
8 years, 10 months ago (2012-02-14 08:52:25 UTC) #3
Søren Gjesse
8 years, 10 months ago (2012-02-14 08:53:13 UTC) #4
https://chromiumcodereview.appspot.com/9363039/diff/1/runtime/tests/vm/vm.status
File runtime/tests/vm/vm.status (right):

https://chromiumcodereview.appspot.com/9363039/diff/1/runtime/tests/vm/vm.sta...
runtime/tests/vm/vm.status:12: ThreadPoolstartStop: Skip
On 2012/02/14 08:51:59, ricow1 wrote:
> Unintentional edit?

Yes, thanks, reverted.

Powered by Google App Engine
This is Rietveld 408576698