Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 9361037: remove closure references (Closed)

Created:
8 years, 10 months ago by danrubel
Modified:
8 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Messages

Total messages: 4 (0 generated)
danrubel
8 years, 10 months ago (2012-02-08 16:08:06 UTC) #1
Mark R Russell
lgtm http://codereview.chromium.org/9361037/diff/1/editor/tools/features/com.google.dart.tools.deploy.feature_releng/build_rcp.xml File editor/tools/features/com.google.dart.tools.deploy.feature_releng/build_rcp.xml (right): http://codereview.chromium.org/9361037/diff/1/editor/tools/features/com.google.dart.tools.deploy.feature_releng/build_rcp.xml#newcode542 editor/tools/features/com.google.dart.tools.deploy.feature_releng/build_rcp.xml:542: inheritall="false" inheritrefs="false" / --> In another CL we ...
8 years, 10 months ago (2012-02-08 16:16:25 UTC) #2
danrubel
http://codereview.chromium.org/9361037/diff/1/editor/tools/features/com.google.dart.tools.deploy.feature_releng/build_rcp.xml File editor/tools/features/com.google.dart.tools.deploy.feature_releng/build_rcp.xml (right): http://codereview.chromium.org/9361037/diff/1/editor/tools/features/com.google.dart.tools.deploy.feature_releng/build_rcp.xml#newcode542 editor/tools/features/com.google.dart.tools.deploy.feature_releng/build_rcp.xml:542: inheritall="false" inheritrefs="false" / --> On 2012/02/08 16:16:25, Mark R ...
8 years, 10 months ago (2012-02-08 16:21:05 UTC) #3
devoncarew
8 years, 10 months ago (2012-02-08 16:45:13 UTC) #4
lgtm

Woe to the source mapping. I'll remove that DartSourceMapping file at some point
-

Powered by Google App Engine
This is Rietveld 408576698