Fix potential flakiness of SocketStreamCloseTest.

Fix potential flakiness of SocketStreamCloseTest.

Not reading out all 5 bytes before moving on. 


R=sgjesse@google.com
BUG=
TEST=

[Søren Gjesse, 2012-02-08 15:03:54]

lgtm

How about adding


// VMOptions=
// VMOptions=--short_socket_read
// VMOptions=--short_socket_write
// VMOptions=--short_socket_read --short_socket_write

to the top of the test as well?

[Mads Ager (google), 2012-02-09 18:42:53]

Adding the flags turned out to be a very good idea. Updated the tests to work
with short reads and writes. Updated the socket implementation to deal correctly
with repeated closing.

If you closed a socket twice you would get the socket registered as a timeout
(id == -1) and a null would be posted back on the port. Hilarity ensues. :)

[Søren Gjesse, 2012-02-09 20:19:42]

LGTM!

Nice work!

https://chromiumcodereview.appspot.com/9361034/diff/3001/runtime/bin/socket_i...
File runtime/bin/socket_impl.dart (right):

https://chromiumcodereview.appspot.com/9361034/diff/3001/runtime/bin/socket_i...
runtime/bin/socket_impl.dart:170: _EventHandler._sendData(_id, _handler, data);
Add assert(_id >= 0) here.

https://chromiumcodereview.appspot.com/9361034/diff/3001/tests/standalone/src...
File tests/standalone/src/SocketStreamCloseTest.dart (right):

https://chromiumcodereview.appspot.com/9361034/diff/3001/tests/standalone/src...
tests/standalone/src/SocketStreamCloseTest.dart:228:
connection.outputStream.write("Hello".charCodes());
Maybe we should add two more cases (variants of 3 and 6) with

connection.outputStream.write("Hello".charCodes());
connection.inputStream.close();

without the use of noPendingWriteHandler, as that should be supported as well.

https://chromiumcodereview.appspot.com/9361034/diff/3001/tests/standalone/src...
tests/standalone/src/SocketStreamCloseTest.dart:230:
print("connection.inputStream.close();");
Debug print.

[Mads Ager (google), 2012-02-10 06:56:47]

https://chromiumcodereview.appspot.com/9361034/diff/3001/runtime/bin/socket_i...
File runtime/bin/socket_impl.dart (right):

https://chromiumcodereview.appspot.com/9361034/diff/3001/runtime/bin/socket_i...
runtime/bin/socket_impl.dart:170: _EventHandler._sendData(_id, _handler, data);
On 2012/02/09 20:19:42, Søren Gjesse wrote:
> Add assert(_id >= 0) here.

Done.

https://chromiumcodereview.appspot.com/9361034/diff/3001/tests/standalone/src...
File tests/standalone/src/SocketStreamCloseTest.dart (right):

https://chromiumcodereview.appspot.com/9361034/diff/3001/tests/standalone/src...
tests/standalone/src/SocketStreamCloseTest.dart:228:
connection.outputStream.write("Hello".charCodes());
On 2012/02/09 20:19:42, Søren Gjesse wrote:
> Maybe we should add two more cases (variants of 3 and 6) with
> 
> connection.outputStream.write("Hello".charCodes());
> connection.inputStream.close();
> 
> without the use of noPendingWriteHandler, as that should be supported as well.

Done.

https://chromiumcodereview.appspot.com/9361034/diff/3001/tests/standalone/src...
tests/standalone/src/SocketStreamCloseTest.dart:230:
print("connection.inputStream.close();");
On 2012/02/09 20:19:42, Søren Gjesse wrote:
> Debug print.

Done.